* [PATCH] Fix kexec compile error, undeclared 'vmlist'
@ 2008-10-21 10:52 Jens Axboe
2008-10-21 10:54 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Jens Axboe @ 2008-10-21 10:52 UTC (permalink / raw)
To: linux-kernel; +Cc: Linus Torvalds, Andrew Morton, oomichi
Hi,
Current -git fails to compile, at least on ppc:
kernel/kexec.c: In function 'crash_save_vmcoreinfo_init':
kernel/kexec.c:1374: error: 'vmlist' undeclared (first use in this function)
kernel/kexec.c:1374: error: (Each undeclared identifier is reported only once
kernel/kexec.c:1374: error: for each function it appears in.)
kernel/kexec.c:1410: error: invalid use of undefined type 'struct vm_struct'
It's missing a vmalloc.h include, introduced by
acd99dbf54020f5c80b9aa2f2ea86f43cb285b02.
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
diff --git a/kernel/kexec.c b/kernel/kexec.c
index 777ac45..ac0fde7 100644
--- a/kernel/kexec.c
+++ b/kernel/kexec.c
@@ -30,6 +30,7 @@
#include <linux/pm.h>
#include <linux/cpu.h>
#include <linux/console.h>
+#include <linux/vmalloc.h>
#include <asm/page.h>
#include <asm/uaccess.h>
--
Jens Axboe
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Fix kexec compile error, undeclared 'vmlist'
2008-10-21 10:52 [PATCH] Fix kexec compile error, undeclared 'vmlist' Jens Axboe
@ 2008-10-21 10:54 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2008-10-21 10:54 UTC (permalink / raw)
To: linux-kernel; +Cc: Linus Torvalds, Andrew Morton, oomichi
On Tue, Oct 21 2008, Jens Axboe wrote:
> Hi,
>
> Current -git fails to compile, at least on ppc:
>
> kernel/kexec.c: In function 'crash_save_vmcoreinfo_init':
> kernel/kexec.c:1374: error: 'vmlist' undeclared (first use in this function)
> kernel/kexec.c:1374: error: (Each undeclared identifier is reported only once
> kernel/kexec.c:1374: error: for each function it appears in.)
> kernel/kexec.c:1410: error: invalid use of undefined type 'struct vm_struct'
>
> It's missing a vmalloc.h include, introduced by
> acd99dbf54020f5c80b9aa2f2ea86f43cb285b02.
>
> Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
>
> diff --git a/kernel/kexec.c b/kernel/kexec.c
> index 777ac45..ac0fde7 100644
> --- a/kernel/kexec.c
> +++ b/kernel/kexec.c
> @@ -30,6 +30,7 @@
> #include <linux/pm.h>
> #include <linux/cpu.h>
> #include <linux/console.h>
> +#include <linux/vmalloc.h>
>
> #include <asm/page.h>
> #include <asm/uaccess.h>
So this was already fixed and pushed out by Tony, so nevermind the extra
noise. Apparently I had pulled this morning just before, so missed the
last few changes.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-21 10:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-21 10:52 [PATCH] Fix kexec compile error, undeclared 'vmlist' Jens Axboe
2008-10-21 10:54 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox