From: Ingo Molnar <mingo@elte.hu>
To: David John <davidjon@xenontk.org>
Cc: akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk,
linux-kernel@vger.kernel.org, venkatesh.pallipadi@intel.com,
tglx@linutronix.de, andi@firstfloor.org
Subject: Re: [PATCH v5] HPET: Remove the BKL.
Date: Tue, 21 Oct 2008 13:34:56 +0200 [thread overview]
Message-ID: <20081021113456.GA14529@elte.hu> (raw)
In-Reply-To: <1224568707-2361-1-git-send-email-davidjon@xenontk.org>
* David John <davidjon@xenontk.org> wrote:
> Remove calls to the BKL as concurrent access is protected
> by the spinlock hpet_lock.
>
> Signed-off-by: David John <davidjon@xenontk.org>
> ---
> drivers/char/hpet.c | 41 ++++++++++++++++++++++++-----------------
> 1 files changed, 24 insertions(+), 17 deletions(-)
this patch still needs to add locking documentation commits to hpet.c,
which shows that you considered all the locking changes that happen due
to dropping the BKL. Most of this code runs very rarely so there's
little chance that races will be caught in practice in any debuggable
manner.
Ingo
next prev parent reply other threads:[~2008-10-21 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 5:58 [PATCH v5] HPET: Remove the BKL David John
2008-10-21 11:34 ` Ingo Molnar [this message]
2008-10-21 11:52 ` David John
2008-10-21 17:35 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021113456.GA14529@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=andi@firstfloor.org \
--cc=davidjon@xenontk.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox