From: Andi Kleen <andi@firstfloor.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andi Kleen <andi@firstfloor.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
"David S. Miller" <davem@davemloft.net>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
David Howells <dhowells@redhat.com>
Subject: Re: [announce] new tree: "fix all build warnings, on all configs"
Date: Tue, 21 Oct 2008 14:07:20 +0200 [thread overview]
Message-ID: <20081021120720.GG12825@one.firstfloor.org> (raw)
In-Reply-To: <20081021111716.GA4476@elte.hu>
On Tue, Oct 21, 2008 at 01:17:16PM +0200, Ingo Molnar wrote:
>
> * Andi Kleen <andi@firstfloor.org> wrote:
>
> > > * acpi_pm_disable_gpes - Disable the GPEs.
> > > */
> > > -static int acpi_pm_disable_gpes(void)
> > > +static inline int acpi_pm_disable_gpes(void)
> >
> > Just to satisfy my curiosity, what compiler warning does marking
> > functions inline fix?
>
> the commit log below explains the situation. The warning exposed a maze
> of #ifdefs in drivers/acpi/sleep/main.c. It's not the warning we need to
> "fix" but that maze, obviously.
Thanks. That makes sense,
I also agree with you that the better alternative would be
to just always force SUSPEND together with ACPI.
I suspect the code delta wouldn't be very large compared to the rest
of the ACPI code.
-Andi
next prev parent reply other threads:[~2008-10-21 12:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 17:11 [announce] new tree: "fix all build warnings, on all configs" Ingo Molnar
2008-10-17 17:59 ` Roland Dreier
2008-10-17 18:05 ` Ingo Molnar
2008-10-17 18:47 ` Roland Dreier
2008-10-17 19:12 ` Ingo Molnar
2008-10-17 19:36 ` Roland Dreier
2008-10-18 8:22 ` Ingo Molnar
2008-10-20 16:37 ` Linus Torvalds
2008-10-20 16:49 ` H. Peter Anvin
2008-10-20 16:57 ` Linus Torvalds
2008-10-20 19:21 ` Ingo Molnar
2008-10-21 6:41 ` Jörn Engel
2008-10-22 9:47 ` Ingo Molnar
2008-10-22 10:10 ` Jörn Engel
2008-10-18 7:43 ` Andi Kleen
2008-10-21 10:30 ` [announce] new tree: "fix all build warnings, on all configs" II Andi Kleen
2008-10-21 11:17 ` [announce] new tree: "fix all build warnings, on all configs" Ingo Molnar
2008-10-21 12:07 ` Andi Kleen [this message]
2008-10-21 19:39 ` Rafael J. Wysocki
2008-10-21 19:37 ` Rafael J. Wysocki
2008-10-22 4:11 ` Len Brown
2008-10-22 12:23 ` [PATCH] ACPI suspend: Fix CONFIG_ACPI_SLEEP dependence and some compilation warnings (was: Re: [announce] new tree: "fix all build warnings, on all configs") Rafael J. Wysocki
2008-10-22 18:58 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081021120720.GG12825@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox