Re: [PATCH 1/2] Add c2 port support.

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 22 Oct 2008 10:40:04 -0700 Greg KH <greg@kroah.com> wrote:

> On Wed, Oct 22, 2008 at 03:47:19PM +0200, Rodolfo Giometti wrote:
> > C2port implements a two wire serial communication protocol (bit
> > banging) designed to enable in-system programming, debugging, and
> > boundary-scan testing on low pin-count Silicon Labs devices.
> > 
> > Currently this code supports only flash programming through sysfs
> > interface but extensions shoud be easy to add.
> > 
> > Signed-off-by: Rodolfo Giometti <giometti@linux.it>
> Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
> 
> Nice job.
> 
> Andrew, no reason why these 2 patches can't go into 2.6.28, they are
> self-contained and are new drivers.
> 
> Do you want to send them to Linus, or want me to?
> 

No opinion yet - I haven't review them.

<looks>

<wonders why c2port_idr_lock and c2port_idr are kernel-wide symbols>

<wonders what local_irq_disable() is supposed to achieve on SMP>

<spots an error-path memory leak in c2port_device_register>

<spots a stray semicolon in c2port_device_register>

<suggests that update_lock be initialised at compile-time, not at runtime>


What I haven't yet got my head around is this:

  Currently this code supports only flash programming through sysfs
  interface but extensions shoud be easy to add.

is that really what we want to use sysfs for?  As the prime interface
to a device driver (or is it a bus driver?) Didn't we used to use
device nodes for that sort of thing?