From: Andrew Morton <akpm@linux-foundation.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, fweisbec@gmail.com,
sagar.abhishek@gmail.com, davem@davemloft.net,
tglx@linutronix.de, peterz@infradead.org,
torvalds@linux-foundation.org, srostedt@redhat.com
Subject: Re: [PATCH 04/11] ftrace: comment arch ftrace code
Date: Wed, 22 Oct 2008 12:26:54 -0700 [thread overview]
Message-ID: <20081022122654.744d9e85.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.DEB.1.10.0810221513490.25759@gandalf.stny.rr.com>
On Wed, 22 Oct 2008 15:16:33 -0400 (EDT)
Steven Rostedt <rostedt@goodmis.org> wrote:
> > Also, I hope that the above code is called from within a
> > pagefault_disable()d region? Or are relying upon some magical
> > side-effect of something which happens to do the same thing as
> > pagefault_disable()? IOW: by what means does the above code ensure
> > that do_page_fault() will see in_atomic()==true?
>
> This code is called from kstop_machine, or simply has interrupts disabled.
in_atomic() doesn't test irqs_disabled()!
Still, probe_kernel_write() correctly handles the
secret-argument-passing to do_page_fault().
next prev parent reply other threads:[~2008-10-22 19:28 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 18:43 [PATCH 00/11] ftrace: clean ups and fixes Steven Rostedt
2008-10-22 18:43 ` [PATCH 01/11] ftrace: handle generic arch calls Steven Rostedt
2008-10-22 18:56 ` Andrew Morton
2008-10-22 19:02 ` Steven Rostedt
2008-10-27 17:41 ` Steven Rostedt
2008-10-29 19:00 ` Sam Ravnborg
2008-10-29 19:14 ` Steven Rostedt
2008-10-29 19:24 ` Steven Rostedt
2008-10-29 19:49 ` Sam Ravnborg
2008-10-29 20:16 ` Adrian Bunk
2008-10-29 20:23 ` Steven Rostedt
2008-10-29 20:31 ` Adrian Bunk
2008-10-29 20:22 ` Adrian Bunk
2008-10-29 19:30 ` [PATCH] ftrace, kbuild: condense recordmcount.pl parameter code Steven Rostedt
2008-10-30 23:37 ` Ingo Molnar
2008-10-31 16:16 ` Sam Ravnborg
2008-10-22 18:43 ` [PATCH 02/11] ftrace: dynamic ftrace process only text section Steven Rostedt
2008-10-22 18:43 ` [PATCH 03/11] ftrace: return error on failed modified text Steven Rostedt
2008-10-22 18:55 ` Steven Rostedt
2008-10-22 18:57 ` Andrew Morton
2008-10-22 19:03 ` Steven Rostedt
2008-10-22 18:43 ` [PATCH 04/11] ftrace: comment arch ftrace code Steven Rostedt
2008-10-22 19:09 ` Andrew Morton
2008-10-22 19:16 ` Steven Rostedt
2008-10-22 19:26 ` Andrew Morton [this message]
2008-10-22 18:43 ` [PATCH 05/11] ftrace: only have ftrace_kill atomic Steven Rostedt
2008-10-22 19:11 ` Andrew Morton
2008-10-22 19:18 ` Steven Rostedt
2008-10-22 19:27 ` Andrew Morton
2008-10-22 18:43 ` [PATCH 06/11] ftrace: add ftrace warn on to disable ftrace Steven Rostedt
2008-10-22 19:12 ` Andrew Morton
2008-10-22 19:20 ` Steven Rostedt
2008-10-22 18:43 ` [PATCH 07/11] ftrace: do not trace init sections Steven Rostedt
2008-10-22 18:43 ` [PATCH 08/11] ftrace: disable dynamic ftrace for all archs that use daemon Steven Rostedt
2008-10-22 18:43 ` [PATCH 09/11] ftrace: remove daemon Steven Rostedt
2008-10-22 18:43 ` [PATCH 10/11] ftrace: remove mcount set Steven Rostedt
2008-10-22 18:43 ` [PATCH 11/11] ftrace: remove ftrace hash Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022122654.744d9e85.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sagar.abhishek@gmail.com \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox