From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Glauber Costa <glommer@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
Max Kellermann <mk@cm4all.com>
Subject: Re: [PATCH -tip] x86: do_boot_cpu - check if we have ESR register
Date: Wed, 22 Oct 2008 16:59:09 +0200 [thread overview]
Message-ID: <20081022145909.GA7224@elte.hu> (raw)
In-Reply-To: <20081022142312.GC26372@elte.hu>
> > | > - apic_write(APIC_ESR, 0);
> > | > - apic_read(APIC_ESR);
> > | > + if (APIC_INTEGRATED(apic_version[phys_apicid])) {
> > | > + apic_write(APIC_ESR, 0);
> > | > + apic_read(APIC_ESR);
> > | > + }
this wouldnt build with certain configs:
arch/x86/kernel/smpboot.c: In function 'do_boot_cpu':
arch/x86/kernel/smpboot.c:897: error: 'phys_apicid' undeclared (first use in this function)
arch/x86/kernel/smpboot.c:897: error: (Each undeclared identifier is reported only once
arch/x86/kernel/smpboot.c:897: error: for each function it appears in.)
include/asm/io_32.h: In function 'memcpy_fromio':
because phys_apicid is not available in the !WAKE_SECONDARY_VIA_INIT
case. Changed it to boot_cpu_physical_apicid - that should be good
enough.
Ingo
next prev parent reply other threads:[~2008-10-22 14:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 14:00 [PATCH -tip] x86: do_boot_cpu - check if we have ESR register Cyrill Gorcunov
2008-10-22 14:13 ` Ingo Molnar
2008-10-22 14:17 ` Glauber Costa
2008-10-22 15:42 ` Maciej W. Rozycki
2008-10-22 14:17 ` Cyrill Gorcunov
2008-10-22 14:23 ` Ingo Molnar
2008-10-22 14:52 ` Cyrill Gorcunov
2008-10-22 14:59 ` Ingo Molnar [this message]
2008-10-22 15:02 ` Cyrill Gorcunov
2008-10-22 15:04 ` Ingo Molnar
2008-10-22 15:06 ` Cyrill Gorcunov
2008-10-22 15:18 ` Max Kellermann
2008-10-22 15:52 ` Maciej W. Rozycki
2008-10-22 15:41 ` Maciej W. Rozycki
2008-10-22 15:29 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022145909.GA7224@elte.hu \
--to=mingo@elte.hu \
--cc=glommer@gmail.com \
--cc=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mk@cm4all.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox