* [PATCH] ring-buffer: fix free page
@ 2008-10-13 14:22 Steven Rostedt
2008-10-22 15:02 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Steven Rostedt @ 2008-10-13 14:22 UTC (permalink / raw)
To: Ingo Molnar; +Cc: LKML, Andrew Morton, Linus Torvalds
The pages of a buffer was originally pointing to the page struct, it
now points to the page address. The freeing of the page still uses
the page frame free "__free_page" instead of the correct free_page to
the address.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
kernel/trace/ring_buffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux-tip.git/kernel/trace/ring_buffer.c
===================================================================
--- linux-tip.git.orig/kernel/trace/ring_buffer.c 2008-10-13 10:15:16.000000000 -0400
+++ linux-tip.git/kernel/trace/ring_buffer.c 2008-10-13 10:17:03.000000000 -0400
@@ -130,7 +130,7 @@ struct buffer_page {
static inline void free_buffer_page(struct buffer_page *bpage)
{
if (bpage->page)
- __free_page(bpage->page);
+ free_page((unsigned long)bpage->page);
kfree(bpage);
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] ring-buffer: fix free page
2008-10-13 14:22 [PATCH] ring-buffer: fix free page Steven Rostedt
@ 2008-10-22 15:02 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-10-22 15:02 UTC (permalink / raw)
To: Steven Rostedt; +Cc: LKML, Andrew Morton, Linus Torvalds
* Steven Rostedt <rostedt@goodmis.org> wrote:
>
> The pages of a buffer was originally pointing to the page struct, it
> now points to the page address. The freeing of the page still uses
> the page frame free "__free_page" instead of the correct free_page to
> the address.
>
> Signed-off-by: Steven Rostedt <srostedt@redhat.com>
> ---
> kernel/trace/ring_buffer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
applied to tip/tracing/urgent, thanks Steve!
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-10-22 15:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-13 14:22 [PATCH] ring-buffer: fix free page Steven Rostedt
2008-10-22 15:02 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox