public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH linux-tip] x86: Change OPTIMIZE_INLINING help to say enabling makes smaller kernels
@ 2008-10-11 19:27 Sitsofe Wheeler
  2008-10-22 16:04 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Sitsofe Wheeler @ 2008-10-11 19:27 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: linux-kernel

The OPTIMIZE_INLINING help currently says "The gcc 4.x series have a
rewritten inlining algorithm and disabling this option will generate a
smaller kernel there."

This contradicts other parts of the help text and my own tests:
5463127 2008-10-11 19:51 vmlinux.no-opt
5456152 2008-10-11 19:56 vmlinux.opt

Reword text to say that enabling OPTIMIZE_INLINING will lead to smaller
kernels with gcc 4.x or later.

Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>
---

diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug
index 6a75bc2..bdddfbc 100644
--- a/arch/x86/Kconfig.debug
+++ b/arch/x86/Kconfig.debug
@@ -395,10 +395,10 @@ config OPTIMIZE_INLINING
 	  developers have marked 'inline'. Doing so takes away freedom from gcc to
 	  do what it thinks is best, which is desirable for the gcc 3.x series of
 	  compilers. The gcc 4.x series have a rewritten inlining algorithm and
-	  disabling this option will generate a smaller kernel there. Hopefully
-	  this algorithm is so good that allowing gcc4 to make the decision can
-	  become the default in the future, until then this option is there to
-	  test gcc for this.
+	  enabling this option will generate a smaller kernel there. Hopefully
+	  this algorithm is so good that allowing gcc 4.x and above to make the
+	  decision will become the default in the future. Until then this option
+	  is there to test gcc for this.
 
 	  If unsure, say N.
 
-- 
Sitsofe | http://sucs.org/~sits/

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH linux-tip] x86: Change OPTIMIZE_INLINING help to say enabling makes smaller kernels
  2008-10-11 19:27 [PATCH linux-tip] x86: Change OPTIMIZE_INLINING help to say enabling makes smaller kernels Sitsofe Wheeler
@ 2008-10-22 16:04 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-10-22 16:04 UTC (permalink / raw)
  To: Sitsofe Wheeler; +Cc: linux-kernel, Thomas Gleixner, H. Peter Anvin


* Sitsofe Wheeler <sitsofe@yahoo.com> wrote:

> The OPTIMIZE_INLINING help currently says "The gcc 4.x series have a
> rewritten inlining algorithm and disabling this option will generate a
> smaller kernel there."
> 
> This contradicts other parts of the help text and my own tests:
> 5463127 2008-10-11 19:51 vmlinux.no-opt
> 5456152 2008-10-11 19:56 vmlinux.opt
> 
> Reword text to say that enabling OPTIMIZE_INLINING will lead to smaller
> kernels with gcc 4.x or later.
> 
> Signed-off-by: Sitsofe Wheeler <sitsofe@yahoo.com>

applied, thanks Sitsofe!

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-10-22 16:04 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-11 19:27 [PATCH linux-tip] x86: Change OPTIMIZE_INLINING help to say enabling makes smaller kernels Sitsofe Wheeler
2008-10-22 16:04 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox