From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Christoph Lameter <cl@linux-foundation.org>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] SLUB - define OO_ macro instead of hardcoded numbers
Date: Wed, 22 Oct 2008 20:35:30 +0400 [thread overview]
Message-ID: <20081022163530.GH9639@localhost> (raw)
In-Reply-To: <Pine.LNX.4.64.0810220926130.7633@quilx.com>
[Christoph Lameter - Wed, Oct 22, 2008 at 09:28:14AM -0700]
> On Wed, 22 Oct 2008, Cyrill Gorcunov wrote:
>
>> Please check -- wouldn't it be better to use such a macro?
>
> Looks good. But could you rename OO_MAX to something different? There is
> already s->max which may cause confusion because s->max is the maximum
> number of objects in a slab. OO_MAX is the maximum mask?
>
I supposed it would mean maximum object number inside page (ie quantity) which
is happen to be the same value as OO_MASK. Maybe OO_MAX_OBJ?
- Cyrill -
next prev parent reply other threads:[~2008-10-22 16:35 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 16:18 [RFC] SLUB - define OO_ macro instead of hardcoded numbers Cyrill Gorcunov
2008-10-22 16:28 ` Christoph Lameter
2008-10-22 16:35 ` Cyrill Gorcunov [this message]
2008-10-22 16:53 ` Cyrill Gorcunov
2008-10-22 17:21 ` Cyrill Gorcunov
2008-10-22 17:47 ` Christoph Lameter
2008-10-22 17:50 ` Pekka Enberg
2008-10-22 17:58 ` Cyrill Gorcunov
2008-10-22 18:01 ` Pekka Enberg
2008-10-22 18:10 ` Christoph Lameter
2008-10-22 18:15 ` Cyrill Gorcunov
2008-10-22 18:24 ` Christoph Lameter
2008-10-22 18:30 ` Cyrill Gorcunov
2008-10-22 18:45 ` Christoph Lameter
2008-10-22 18:52 ` Cyrill Gorcunov
2008-10-22 18:42 ` Cyrill Gorcunov
2008-10-22 18:49 ` Christoph Lameter
2008-10-22 18:53 ` Cyrill Gorcunov
2008-10-22 18:03 ` Christoph Lameter
2008-10-22 17:54 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081022163530.GH9639@localhost \
--to=gorcunov@gmail.com \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox