public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Abhishek Sagar <sagar.abhishek@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH 02/11] ftrace: dynamic ftrace process only text section
Date: Wed, 22 Oct 2008 14:43:15 -0400	[thread overview]
Message-ID: <20081022185135.782875066@goodmis.org> (raw)
In-Reply-To: 20081022184313.179487464@goodmis.org

[-- Attachment #1: ftrace-record-only-text.patch --]
[-- Type: text/plain, Size: 2198 bytes --]

The text section stays in memory without ever leaving. With the exception
of modules, but modules know how to handle that case. With the dynamic
ftrace tracer, we need to make sure that it does not try to modify code
that no longer exists. The only safe section is .text.

This patch changes the recordmcount script to only record the mcount calls
in the .text sections.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
 scripts/recordmcount.pl |   17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

Index: linux-compile.git/scripts/recordmcount.pl
===================================================================
--- linux-compile.git.orig/scripts/recordmcount.pl	2008-10-22 11:45:59.000000000 -0400
+++ linux-compile.git/scripts/recordmcount.pl	2008-10-22 11:46:33.000000000 -0400
@@ -109,6 +109,11 @@ if ($#ARGV < 6) {
 my ($arch, $bits, $objdump, $objcopy, $cc,
     $ld, $nm, $rm, $mv, $inputfile) = @ARGV;
 
+# Acceptible sections to record.
+my %text_sections = (
+     ".text" => 1,
+);
+
 $objdump = "objdump" if ((length $objdump) == 0);
 $objcopy = "objcopy" if ((length $objcopy) == 0);
 $cc = "gcc" if ((length $cc) == 0);
@@ -139,7 +144,7 @@ if ($arch eq "x86") {
 }
 
 if ($arch eq "x86_64") {
-    $section_regex = "Disassembly of section";
+    $section_regex = "Disassembly of section\\s+(\\S+):";
     $function_regex = "^([0-9a-fA-F]+)\\s+<(.*?)>:";
     $mcount_regex = "^\\s*([0-9a-fA-F]+):.*\\smcount([+-]0x[0-9a-zA-Z]+)?\$";
     $type = ".quad";
@@ -151,7 +156,7 @@ if ($arch eq "x86_64") {
     $cc .= " -m64";
 
 } elsif ($arch eq "i386") {
-    $section_regex = "Disassembly of section";
+    $section_regex = "Disassembly of section\\s+(\\S+):";
     $function_regex = "^([0-9a-fA-F]+)\\s+<(.*?)>:";
     $mcount_regex = "^\\s*([0-9a-fA-F]+):.*\\smcount\$";
     $type = ".long";
@@ -298,7 +303,13 @@ my $text;
 while (<IN>) {
     # is it a section?
     if (/$section_regex/) {
-	$read_function = 1;
+
+	# Only record text sections that we know are safe
+	if (defined($text_sections{$1})) {
+	    $read_function = 1;
+	} else {
+	    $read_function = 0;
+	}
 	# print out any recorded offsets
 	update_funcs() if ($text_found);
 

-- 

  parent reply	other threads:[~2008-10-22 18:55 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-22 18:43 [PATCH 00/11] ftrace: clean ups and fixes Steven Rostedt
2008-10-22 18:43 ` [PATCH 01/11] ftrace: handle generic arch calls Steven Rostedt
2008-10-22 18:56   ` Andrew Morton
2008-10-22 19:02     ` Steven Rostedt
2008-10-27 17:41   ` Steven Rostedt
2008-10-29 19:00     ` Sam Ravnborg
2008-10-29 19:14       ` Steven Rostedt
2008-10-29 19:24       ` Steven Rostedt
2008-10-29 19:49         ` Sam Ravnborg
2008-10-29 20:16           ` Adrian Bunk
2008-10-29 20:23             ` Steven Rostedt
2008-10-29 20:31               ` Adrian Bunk
2008-10-29 20:22         ` Adrian Bunk
2008-10-29 19:30       ` [PATCH] ftrace, kbuild: condense recordmcount.pl parameter code Steven Rostedt
2008-10-30 23:37         ` Ingo Molnar
2008-10-31 16:16           ` Sam Ravnborg
2008-10-22 18:43 ` Steven Rostedt [this message]
2008-10-22 18:43 ` [PATCH 03/11] ftrace: return error on failed modified text Steven Rostedt
2008-10-22 18:55   ` Steven Rostedt
2008-10-22 18:57   ` Andrew Morton
2008-10-22 19:03     ` Steven Rostedt
2008-10-22 18:43 ` [PATCH 04/11] ftrace: comment arch ftrace code Steven Rostedt
2008-10-22 19:09   ` Andrew Morton
2008-10-22 19:16     ` Steven Rostedt
2008-10-22 19:26       ` Andrew Morton
2008-10-22 18:43 ` [PATCH 05/11] ftrace: only have ftrace_kill atomic Steven Rostedt
2008-10-22 19:11   ` Andrew Morton
2008-10-22 19:18     ` Steven Rostedt
2008-10-22 19:27       ` Andrew Morton
2008-10-22 18:43 ` [PATCH 06/11] ftrace: add ftrace warn on to disable ftrace Steven Rostedt
2008-10-22 19:12   ` Andrew Morton
2008-10-22 19:20     ` Steven Rostedt
2008-10-22 18:43 ` [PATCH 07/11] ftrace: do not trace init sections Steven Rostedt
2008-10-22 18:43 ` [PATCH 08/11] ftrace: disable dynamic ftrace for all archs that use daemon Steven Rostedt
2008-10-22 18:43 ` [PATCH 09/11] ftrace: remove daemon Steven Rostedt
2008-10-22 18:43 ` [PATCH 10/11] ftrace: remove mcount set Steven Rostedt
2008-10-22 18:43 ` [PATCH 11/11] ftrace: remove ftrace hash Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081022185135.782875066@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=sagar.abhishek@gmail.com \
    --cc=srostedt@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox