public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	Abhishek Sagar <sagar.abhishek@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH 06/11] ftrace: add ftrace warn on to disable ftrace
Date: Wed, 22 Oct 2008 14:43:19 -0400	[thread overview]
Message-ID: <20081022185136.489385614@goodmis.org> (raw)
In-Reply-To: 20081022184313.179487464@goodmis.org

[-- Attachment #1: ftrace-disable-warn-on.patch --]
[-- Type: text/plain, Size: 2105 bytes --]

Add ftrace warn on to disable ftrace as well as report a warning.

Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
 kernel/trace/ftrace.c |   29 ++++++++++++++++++++++-------
 1 file changed, 22 insertions(+), 7 deletions(-)

Index: linux-compile.git/kernel/trace/ftrace.c
===================================================================
--- linux-compile.git.orig/kernel/trace/ftrace.c	2008-10-22 13:17:29.000000000 -0400
+++ linux-compile.git/kernel/trace/ftrace.c	2008-10-22 13:20:11.000000000 -0400
@@ -32,6 +32,24 @@
 
 #include "trace.h"
 
+#define FTRACE_WARN_ON(cond)			\
+	do {					\
+		if (unlikely(cond)) {		\
+			WARN_ON(1);		\
+			ftrace_kill();		\
+		}				\
+	} while (0)
+
+#define FTRACE_WARN_ON_ONCE(cond)		\
+	do {					\
+		static int once;		\
+		if (unlikely(cond) && !once) {	\
+			once++;			\
+			WARN_ON(1);		\
+			ftrace_kill();		\
+		}				\
+	} while (0)
+
 /* ftrace_enabled is a method to turn ftrace on or off */
 int ftrace_enabled __read_mostly;
 static int last_ftrace_enabled;
@@ -358,10 +376,8 @@ static struct dyn_ftrace *ftrace_alloc_d
 		rec = ftrace_free_records;
 
 		if (unlikely(!(rec->flags & FTRACE_FL_FREE))) {
-			WARN_ON_ONCE(1);
+			FTRACE_WARN_ON_ONCE(1);
 			ftrace_free_records = NULL;
-			ftrace_disabled = 1;
-			ftrace_enabled = 0;
 			return NULL;
 		}
 
@@ -410,7 +426,7 @@ ftrace_record_ip(unsigned long ip)
 
 	key = hash_long(ip, FTRACE_HASHBITS);
 
-	WARN_ON_ONCE(key >= FTRACE_HASHSIZE);
+	FTRACE_WARN_ON_ONCE(key >= FTRACE_HASHSIZE);
 
 	if (ftrace_ip_in_hash(ip, key))
 		goto out;
@@ -600,7 +616,7 @@ ftrace_code_disable(struct dyn_ftrace *r
 
 	ret = ftrace_modify_code(ip, call, nop);
 	if (ret) {
-		WARN_ON_ONCE(1);
+		FTRACE_WARN_ON_ONCE(1);
 		pr_info("ftrace failed to modify ");
 		print_ip_sym(ip);
 		print_ip_ins(" expected: ", call);
@@ -1660,8 +1676,7 @@ static int ftraced(void *ignore)
 					ftrace_update_cnt != 1 ? "s" : "",
 					ftrace_update_tot_cnt,
 					usecs, usecs != 1 ? "s" : "");
-				ftrace_disabled = 1;
-				WARN_ON_ONCE(1);
+				FTRACE_WARN_ON_ONCE(1);
 			}
 		}
 		mutex_unlock(&ftraced_lock);

-- 

  parent reply	other threads:[~2008-10-22 18:53 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-22 18:43 [PATCH 00/11] ftrace: clean ups and fixes Steven Rostedt
2008-10-22 18:43 ` [PATCH 01/11] ftrace: handle generic arch calls Steven Rostedt
2008-10-22 18:56   ` Andrew Morton
2008-10-22 19:02     ` Steven Rostedt
2008-10-27 17:41   ` Steven Rostedt
2008-10-29 19:00     ` Sam Ravnborg
2008-10-29 19:14       ` Steven Rostedt
2008-10-29 19:24       ` Steven Rostedt
2008-10-29 19:49         ` Sam Ravnborg
2008-10-29 20:16           ` Adrian Bunk
2008-10-29 20:23             ` Steven Rostedt
2008-10-29 20:31               ` Adrian Bunk
2008-10-29 20:22         ` Adrian Bunk
2008-10-29 19:30       ` [PATCH] ftrace, kbuild: condense recordmcount.pl parameter code Steven Rostedt
2008-10-30 23:37         ` Ingo Molnar
2008-10-31 16:16           ` Sam Ravnborg
2008-10-22 18:43 ` [PATCH 02/11] ftrace: dynamic ftrace process only text section Steven Rostedt
2008-10-22 18:43 ` [PATCH 03/11] ftrace: return error on failed modified text Steven Rostedt
2008-10-22 18:55   ` Steven Rostedt
2008-10-22 18:57   ` Andrew Morton
2008-10-22 19:03     ` Steven Rostedt
2008-10-22 18:43 ` [PATCH 04/11] ftrace: comment arch ftrace code Steven Rostedt
2008-10-22 19:09   ` Andrew Morton
2008-10-22 19:16     ` Steven Rostedt
2008-10-22 19:26       ` Andrew Morton
2008-10-22 18:43 ` [PATCH 05/11] ftrace: only have ftrace_kill atomic Steven Rostedt
2008-10-22 19:11   ` Andrew Morton
2008-10-22 19:18     ` Steven Rostedt
2008-10-22 19:27       ` Andrew Morton
2008-10-22 18:43 ` Steven Rostedt [this message]
2008-10-22 19:12   ` [PATCH 06/11] ftrace: add ftrace warn on to disable ftrace Andrew Morton
2008-10-22 19:20     ` Steven Rostedt
2008-10-22 18:43 ` [PATCH 07/11] ftrace: do not trace init sections Steven Rostedt
2008-10-22 18:43 ` [PATCH 08/11] ftrace: disable dynamic ftrace for all archs that use daemon Steven Rostedt
2008-10-22 18:43 ` [PATCH 09/11] ftrace: remove daemon Steven Rostedt
2008-10-22 18:43 ` [PATCH 10/11] ftrace: remove mcount set Steven Rostedt
2008-10-22 18:43 ` [PATCH 11/11] ftrace: remove ftrace hash Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081022185136.489385614@goodmis.org \
    --to=rostedt@goodmis.org \
    --cc=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=peterz@infradead.org \
    --cc=sagar.abhishek@gmail.com \
    --cc=srostedt@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox