From: Alexey Dobriyan <adobriyan@gmail.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] procfs: use WARN() rather than printk+backtrace
Date: Thu, 23 Oct 2008 12:35:47 +0400 [thread overview]
Message-ID: <20081023083547.GA32124@x200.localdomain> (raw)
In-Reply-To: <20081021064612.4578920c@infradead.org>
On Tue, Oct 21, 2008 at 06:46:12AM -0700, Arjan van de Ven wrote:
> - printk(KERN_WARNING "proc_dir_entry '%s/%s' already registered\n",
> + WARN(1, KERN_WARNING "proc_dir_entry '%s/%s' already registered\n",
Applied to proc.git
As a side note, seeing WARN twice on this line is depressing, and people
use WARN(, KERN_ERR);
I mean, how hard is to get something conceptually simple as warning right?
next prev parent reply other threads:[~2008-10-23 8:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 13:46 [PATCH] procfs: use WARN() rather than printk+backtrace Arjan van de Ven
2008-10-23 8:35 ` Alexey Dobriyan [this message]
2008-10-23 13:30 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081023083547.GA32124@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox