public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: Greg Kroah-Hartman <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] w35und: remove unused wb35_open() and wb35_close() functions
Date: Thu, 23 Oct 2008 11:46:32 +0200	[thread overview]
Message-ID: <20081023094632.GC1849@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.64.0810221905550.1679@melkki.cs.Helsinki.FI>

On Wed 2008-10-22 19:06:13, Pekka J Enberg wrote:
> From: Pekka Enberg <penberg@cs.helsinki.fi>
> 
> The functions are not used anywhere so remove them.
> 
> Cc: Pavel Machek <pavel@suse.cz>
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>

ACK.

> ---
>  drivers/staging/winbond/linux/wbusb.c   |   19 -------------------
>  drivers/staging/winbond/linux/wbusb_f.h |    2 --
>  2 files changed, 0 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/staging/winbond/linux/wbusb.c b/drivers/staging/winbond/linux/wbusb.c
> index 4b989c5..c3394bf 100644
> --- a/drivers/staging/winbond/linux/wbusb.c
> +++ b/drivers/staging/winbond/linux/wbusb.c
> @@ -308,25 +308,6 @@ WbUsb_destroy(phw_data_t pHwData)
>  {
>  }
>  
> -int wb35_open(struct net_device *netdev)
> -{
> -	struct wb35_adapter * adapter = (struct wb35_adapter *)netdev->priv;
> -	phw_data_t pHwData = &adapter->sHwData;
> -
> -        netif_start_queue(netdev);
> -
> -	//TODO : put here temporarily
> -	hal_set_accept_broadcast(pHwData, 1); // open accept broadcast
> -
> -	return 0;
> -}
> -
> -int wb35_close(struct net_device *netdev)
> -{
> -	netif_stop_queue(netdev);
> -	return 0;
> -}
> -
>  static void wb35_disconnect(struct usb_interface *intf)
>  {
>  	struct wb35_adapter * adapter = usb_get_intfdata(intf);
> diff --git a/drivers/staging/winbond/linux/wbusb_f.h b/drivers/staging/winbond/linux/wbusb_f.h
> index 0402f66..a1d5946 100644
> --- a/drivers/staging/winbond/linux/wbusb_f.h
> +++ b/drivers/staging/winbond/linux/wbusb_f.h
> @@ -11,8 +11,6 @@
>  //
>  //+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  
> -int wb35_open(struct net_device *netdev);
> -int wb35_close(struct net_device *netdev);
>  unsigned char WbUsb_initial(phw_data_t pHwData);
>  void WbUsb_destroy(phw_data_t pHwData);
>  unsigned char WbWLanInitialize(struct wb35_adapter *adapter);

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

      reply	other threads:[~2008-10-23  9:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-22 16:06 [PATCH 2/5] w35und: remove unused wb35_open() and wb35_close() functions Pekka J Enberg
2008-10-23  9:46 ` Pavel Machek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081023094632.GC1849@elf.ucw.cz \
    --to=pavel@suse.cz \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox