From: Steven Rostedt <rostedt@goodmis.org>
To: linux-kernel@vger.kernel.org
Cc: Ingo Molnar <mingo@elte.hu>,
Frederic Weisbecker <fweisbec@gmail.com>,
Abhishek Sagar <sagar.abhishek@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Zijlstra <peterz@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Wenji Huang <wenji.huang@oracle.com>,
Steven Rostedt <srostedt@redhat.com>
Subject: [PATCH 04/12 v3] ftrace: comment arch ftrace code
Date: Thu, 23 Oct 2008 09:33:00 -0400 [thread overview]
Message-ID: <20081023133723.268161704@goodmis.org> (raw)
In-Reply-To: 20081023133256.926296694@goodmis.org
[-- Attachment #1: ftrace-comment-mod-code.patch --]
[-- Type: text/plain, Size: 1343 bytes --]
Add comments to explain what is happening in the x86 arch ftrace code.
Signed-off-by: Steven Rostedt <srostedt@redhat.com>
---
arch/x86/kernel/ftrace.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
Index: linux-compile.git/arch/x86/kernel/ftrace.c
===================================================================
--- linux-compile.git.orig/arch/x86/kernel/ftrace.c 2008-10-22 15:23:20.000000000 -0400
+++ linux-compile.git/arch/x86/kernel/ftrace.c 2008-10-22 15:24:15.000000000 -0400
@@ -66,18 +66,23 @@ ftrace_modify_code(unsigned long ip, uns
/*
* Note: Due to modules and __init, code can
* disappear and change, we need to protect against faulting
- * as well as code changing.
+ * as well as code changing. We do this by using the
+ * __copy_*_user functions.
*
* No real locking needed, this code is run through
* kstop_machine, or before SMP starts.
*/
+
+ /* read the text we want to modify */
if (__copy_from_user_inatomic(replaced, (char __user *)ip,
MCOUNT_INSN_SIZE))
return -EFAULT;
+ /* Make sure it is what we expect it to be */
if (memcmp(replaced, old_code, MCOUNT_INSN_SIZE) != 0)
return -EINVAL;
+ /* replace the text with the new text */
if (__copy_to_user_inatomic((char __user *)ip, new_code,
MCOUNT_INSN_SIZE))
return -EPERM;
--
next prev parent reply other threads:[~2008-10-23 13:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 13:32 [PATCH 00/12 v3] ftrace: clean ups and fixes Steven Rostedt
2008-10-23 13:32 ` [PATCH 01/12 v3] ftrace: handle generic arch calls Steven Rostedt
2008-10-23 13:32 ` [PATCH 02/12 v3] ftrace: dynamic ftrace process only text section Steven Rostedt
2008-10-23 13:32 ` [PATCH 03/12 v3] ftrace: return error on failed modified text Steven Rostedt
2008-10-23 13:33 ` Steven Rostedt [this message]
2008-10-23 13:33 ` [PATCH 05/12 v3] ftrace: use probe_kernel Steven Rostedt
2008-10-23 13:33 ` [PATCH 06/12 v3] ftrace: only have ftrace_kill atomic Steven Rostedt
2008-10-23 13:33 ` [PATCH 07/12 v3] ftrace: add ftrace warn on to disable ftrace Steven Rostedt
2008-10-23 13:33 ` [PATCH 08/12 v3] ftrace: disable dynamic ftrace for all archs that use daemon Steven Rostedt
2008-10-23 13:33 ` [PATCH 09/12 v3] ftrace: remove daemon Steven Rostedt
2008-10-23 13:33 ` [PATCH 10/12 v3] ftrace: remove mcount set Steven Rostedt
2008-10-23 13:33 ` [PATCH 11/12 v3] ftrace: remove ftrace hash Steven Rostedt
2008-10-23 13:33 ` [PATCH 12/12 v3] ftrace: remove notrace from arch ftrace file Steven Rostedt
2008-10-23 14:07 ` [PATCH 00/12 v3] ftrace: clean ups and fixes Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081023133723.268161704@goodmis.org \
--to=rostedt@goodmis.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=sagar.abhishek@gmail.com \
--cc=srostedt@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=wenji.huang@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox