* asterisk-slash sequence in quoted string confuses checkpatch.pl
@ 2008-10-21 11:25 Tetsuo Handa
2008-10-23 14:14 ` Andy Whitcroft
0 siblings, 1 reply; 3+ messages in thread
From: Tetsuo Handa @ 2008-10-21 11:25 UTC (permalink / raw)
To: apw, rdunlap, jschopp; +Cc: linux-kernel
[Reposting since the webmail system broke the code by adding backslashes. ]
Hello.
The below code confuses checkpatch.pl ver 0.21.
Regards.
----------
# cat /tmp/foo.c
void foo(void)
{
bar(" /proc/\\*/");
bar(" /proc/\\$/");
}
# /usr/src/vanilla/linux-2.6.27.2/scripts/checkpatch.pl --file /tmp/foo.c
ERROR: need consistent spacing around '/' (ctx:WxV)
#4: FILE: tmp/foo.c:4:
+ bar(" /proc/\\$/");
^
total: 1 errors, 0 warnings, 5 lines checked
/tmp/foo.c has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: asterisk-slash sequence in quoted string confuses checkpatch.pl
2008-10-21 11:25 asterisk-slash sequence in quoted string confuses checkpatch.pl Tetsuo Handa
@ 2008-10-23 14:14 ` Andy Whitcroft
2008-10-23 21:36 ` Tetsuo Handa
0 siblings, 1 reply; 3+ messages in thread
From: Andy Whitcroft @ 2008-10-23 14:14 UTC (permalink / raw)
To: Tetsuo Handa; +Cc: rdunlap, jschopp, linux-kernel
On Tue, Oct 21, 2008 at 08:25:09PM +0900, Tetsuo Handa wrote:
> [Reposting since the webmail system broke the code by adding backslashes. ]
>
> Hello.
>
> The below code confuses checkpatch.pl ver 0.21.
>
> Regards.
> ----------
> # cat /tmp/foo.c
> void foo(void)
> {
> bar(" /proc/\\*/");
> bar(" /proc/\\$/");
> }
> # /usr/src/vanilla/linux-2.6.27.2/scripts/checkpatch.pl --file /tmp/foo.c
> ERROR: need consistent spacing around '/' (ctx:WxV)
> #4: FILE: tmp/foo.c:4:
> + bar(" /proc/\\$/");
We believe that this is fixed in the latest release, and indeed I believe
you have acked. But I'll reply again here for completeness.
-apw
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: asterisk-slash sequence in quoted string confuses checkpatch.pl
2008-10-23 14:14 ` Andy Whitcroft
@ 2008-10-23 21:36 ` Tetsuo Handa
0 siblings, 0 replies; 3+ messages in thread
From: Tetsuo Handa @ 2008-10-23 21:36 UTC (permalink / raw)
To: apw; +Cc: rdunlap, jschopp, linux-kernel
Andy Whitcroft wrote:
> We believe that this is fixed in the latest release, and indeed I believe
> you have acked. But I'll reply again here for completeness.
Yes. You figured out that "Most of these \'s are extraneous" before
you notice this reposting.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-10-23 21:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-10-21 11:25 asterisk-slash sequence in quoted string confuses checkpatch.pl Tetsuo Handa
2008-10-23 14:14 ` Andy Whitcroft
2008-10-23 21:36 ` Tetsuo Handa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox