From: lsorense@csclub.uwaterloo.ca (Lennart Sorensen)
To: linux-kernel@vger.kernel.org
Cc: ben-linux@fluff.org, khali@linux-fr.org,
Len Sorensen <lsorense@csclub.uwaterloo.ca>
Subject: scx200_i2c driver fails to detect any i2c devices in 2.6.26
Date: Thu, 23 Oct 2008 12:54:19 -0400 [thread overview]
Message-ID: <20081023165419.GA5682@csclub.uwaterloo.ca> (raw)
In 2.6.18, the scx200_i2c driver was working just fine. Now while
moving to 2.6.26 I find that the bus no longer locates any devices when
drivers are loaded, even though i2cdetect has no problem locating
devices on the bus.
After some searching, I discovered that the scx200_i2c driver doesn't
have a .class parameter filled in, even though every other i2c driver
does. A small patch adding the .class parameter fixes the problem.
Not sure if it should be I2C_CLASS_ALL or I2C_CLASS_HWMON, or even
I2C_CLASS_HWMON | I2C_CLASS_SPD (in current git tree). Using
I2C_CLASS_ALL works for me and works with my lm75, m41t81 and spd
eeprom in 2.6.26.
--- a/drivers/i2c/busses/scx200_i2c.c 2008-07-13 17:51:29.000000000 -0400
+++ b/drivers/i2c/busses/scx200_i2c.c 2008-10-23 12:41:02.000000000 -0400
@@ -81,6 +81,7 @@
static struct i2c_adapter scx200_i2c_ops = {
.owner = THIS_MODULE,
+ .class = I2C_CLASS_ALL,
.id = I2C_HW_B_SCX200,
.algo_data = &scx200_i2c_data,
.name = "NatSemi SCx200 I2C",
--
Len Sorensen
next reply other threads:[~2008-10-23 16:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 16:54 Lennart Sorensen [this message]
2008-10-23 17:20 ` scx200_i2c driver fails to detect any i2c devices in 2.6.26 Jean Delvare
2008-10-23 17:25 ` Lennart Sorensen
2008-10-23 17:35 ` Jean Delvare
2008-10-23 17:53 ` Lennart Sorensen
2008-10-23 17:55 ` scx200_i2c driver fails to detect any i2c devices in 2.6.26 (new patch) Lennart Sorensen
2008-10-23 18:03 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081023165419.GA5682@csclub.uwaterloo.ca \
--to=lsorense@csclub.uwaterloo.ca \
--cc=ben-linux@fluff.org \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox