From: Andrey Mirkin <major@openvz.org>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: devel@openvz.org, containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [Devel] Re: [PATCH 06/10] Introduce functions to dump mm
Date: Fri, 24 Oct 2008 08:07:01 +0400 [thread overview]
Message-ID: <200810240807.02820.major@openvz.org> (raw)
In-Reply-To: <1224769880.12673.15.camel@nimitz>
On Thursday 23 October 2008 17:51 Dave Hansen wrote:
> On Thu, 2008-10-23 at 12:43 +0400, Andrey Mirkin wrote:
> > > > +#ifdef CONFIG_X86
> > > > + if (pmd_huge(*pmd)) {
> > > > + eprintk("page_huge\n");
> > > > + goto out_unsupported;
> > > > + }
> > > > +#endif
> > >
> > > I take it you know that this breaks with the 1GB (x86_64) and 16GB
> > > (ppc) large pages.
> > >
> > > Since you have the VMA, why not use is_vm_hugetlb_page()?
> >
> > Right now I'm checking VM_HUGETLB flag on VMAs in dump_one_vma().
> > This checks were added for sanity purpose just to throw out all
> > unsupported right now cases.
>
> I'm telling you that it's no good. Not only should this path never be
> hit. But, if it is, you'll crash anyway in some cases.
>
> It's a bad check. At best it misleads the reader to think that you've
> covered your bases.
Agree, I will rework this.
Andrey
next prev parent reply other threads:[~2008-10-24 4:07 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-17 23:11 [PATCH 0/10] OpenVZ kernel based checkpointing/restart (v2) Andrey Mirkin
2008-10-17 23:11 ` [PATCH 01/10] Introduce trivial sys_checkpoint and sys_restore system calls Andrey Mirkin
2008-10-17 23:11 ` [PATCH 02/10] Make checkpoint/restart functionality modular Andrey Mirkin
2008-10-17 23:11 ` [PATCH 03/10] Introduce context structure needed during checkpointing/restart Andrey Mirkin
2008-10-17 23:11 ` [PATCH 04/10] Introduce container dump function Andrey Mirkin
2008-10-17 23:11 ` [PATCH 05/10] Introduce function to dump process Andrey Mirkin
2008-10-17 23:11 ` [PATCH 06/10] Introduce functions to dump mm Andrey Mirkin
2008-10-17 23:11 ` [PATCH 07/10] Introduce function for restarting a container Andrey Mirkin
2008-10-17 23:11 ` [PATCH 08/10] Introduce functions to restart a process Andrey Mirkin
2008-10-17 23:11 ` [PATCH 09/10] Introduce functions to restore mm Andrey Mirkin
2008-10-17 23:11 ` [PATCH 10/10] Add support for multiple processes Andrey Mirkin
2008-10-27 15:58 ` Oren Laadan
2008-10-30 4:55 ` [Devel] " Andrey Mirkin
2008-10-20 9:23 ` [PATCH 08/10] Introduce functions to restart a process Cedric Le Goater
2008-10-22 8:49 ` [Devel] " Andrey Mirkin
2008-10-22 9:25 ` Louis Rilling
2008-10-22 10:06 ` Greg Kurz
2008-10-22 10:44 ` Louis Rilling
2008-10-22 12:44 ` Greg Kurz
2008-10-22 10:12 ` Andrey Mirkin
2008-10-22 10:46 ` Louis Rilling
2008-10-23 8:53 ` Andrey Mirkin
2008-10-22 15:25 ` Oren Laadan
2008-10-23 9:00 ` Andrey Mirkin
2008-10-23 13:57 ` Dave Hansen
2008-10-24 3:57 ` Andrey Mirkin
2008-10-25 21:10 ` Oren Laadan
2008-10-29 14:52 ` Andrey Mirkin
2008-10-30 15:59 ` Oren Laadan
2008-10-22 12:47 ` Cedric Le Goater
2008-10-23 9:54 ` Andrey Mirkin
2008-10-23 13:49 ` Dave Hansen
2008-10-24 4:04 ` Andrey Mirkin
2008-10-20 13:25 ` Louis Rilling
2008-10-23 10:56 ` [Devel] " Andrey Mirkin
2008-10-20 12:25 ` [PATCH 06/10] Introduce functions to dump mm Louis Rilling
2008-10-22 8:58 ` [Devel] " Andrey Mirkin
2008-10-20 17:21 ` Dave Hansen
2008-10-23 8:43 ` [Devel] " Andrey Mirkin
2008-10-23 13:51 ` Dave Hansen
2008-10-24 4:07 ` Andrey Mirkin [this message]
2008-10-20 11:02 ` [PATCH 05/10] Introduce function to dump process Louis Rilling
2008-10-24 4:15 ` [Devel] " Andrey Mirkin
2008-10-20 17:48 ` Serge E. Hallyn
2008-10-24 4:40 ` [Devel] " Andrey Mirkin
2008-10-20 17:02 ` [PATCH 03/10] Introduce context structure needed during checkpointing/restart Dave Hansen
2008-10-29 15:30 ` [Devel] " Andrey Mirkin
2008-10-20 16:51 ` [PATCH 02/10] Make checkpoint/restart functionality modular Dave Hansen
2008-10-20 16:59 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810240807.02820.major@openvz.org \
--to=major@openvz.org \
--cc=containers@lists.linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox