From: Rusty Russell <rusty@rustcorp.com.au>
To: Ingo Molnar <mingo@elte.hu>
Cc: Mike Travis <travis@sgi.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [bug] Re: [PATCH 00/35] cpumask: Replace cpumask_t with struct cpumask
Date: Fri, 24 Oct 2008 10:01:53 +1100 [thread overview]
Message-ID: <200810241001.54175.rusty@rustcorp.com.au> (raw)
In-Reply-To: <20081023125529.GA18327@elte.hu>
On Thursday 23 October 2008 23:55:29 Ingo Molnar wrote:
> ok, the new cpumask code blew up in -tip testing, with various sorts of
> slab corruptions during scheduler init:
...
> i suspect it's due to:
>
> 01b8bd9: sched: cpumask: get rid of boutique sched.c allocations, use
> cpumask_va
Just drop it. It's a conversion, so it doesn't really belong in this "new
API" stuff. Nothing depends on it, and we need to be sure it's that which is
causing the blowup.
Oh, and here's (one) problem:
*nodemask = node_to_cpumask(cpu_to_node(i));
This is an old-style cpumask_t assigment, but nodemask wasn't allocated
NR_CPUS bits if CONFIG_CPUMASK_OFFSTACK. This is why assignment is banned
(and will eventually fail compile), but that conversion hasn't been done on
sched.c yet, so this patch is ahead of its time.
Thanks,
Rusty.
next prev parent reply other threads:[~2008-10-23 23:02 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 2:08 [PATCH 00/35] cpumask: Replace cpumask_t with struct cpumask Mike Travis
2008-10-23 2:08 ` [PATCH 01/35] cpumask: add for_each_cpu_mask_and function Mike Travis
2008-10-23 2:08 ` [PATCH 02/35] x86 smp: modify send_IPI_mask interface to accept cpumask_t pointers Mike Travis
2008-10-23 2:08 ` [PATCH 03/35] sched: Reduce stack size requirements in kernel/sched.c Mike Travis
2008-10-23 2:08 ` [PATCH 04/35] cpumask: centralize cpu_online_map and cpu_possible_map Mike Travis
2008-10-23 2:14 ` [PATCH 04/35] cpumask: centralize cpu_online_map and cpu_possible_map - resubmit Mike Travis
2008-10-23 2:08 ` [PATCH 05/35] cpumask: remove min from first_cpu/next_cpu From: Rusty Russell <rusty@rustcorp.com.au> Mike Travis
2008-10-23 2:08 ` [PATCH 06/35] cpumask: introduce struct cpumask. " Mike Travis
2008-10-23 2:08 ` [PATCH 07/35] cpumask: change cpumask/list_scnprintf, cpumask/list_parse to take pointers. " Mike Travis
2008-10-23 2:08 ` [PATCH 08/35] cpumask: cpumask_size() From: Mike Travis <travis@sgi.com> Mike Travis
2008-10-23 2:08 ` [PATCH 09/35] cpumask: add cpumask_copy() Mike Travis
2008-10-23 2:08 ` [PATCH 10/35] cpumask: introduce cpumask_var_t for local cpumask vars From: Rusty Russell <rusty@rustcorp.com.au> Mike Travis
2008-10-23 2:08 ` [PATCH 11/35] x86: enable MAXSMP Mike Travis
2008-10-23 2:08 ` [PATCH 12/35] cpumask: make CONFIG_NR_CPUS always valid. From: Rusty Russell <rusty@rustcorp.com.au> Mike Travis
2008-10-23 2:08 ` [PATCH 13/35] cpumask: make nr_cpu_ids valid in all configurations. " Mike Travis
2008-10-23 2:08 ` [PATCH 14/35] cpumask: add nr_cpumask_bits Mike Travis
2008-10-23 2:08 ` [PATCH 15/35] cpumask: prepare for iterators to only go to nr_cpu_ids/nr_cpumask_bits. From: Rusty Russell <rusty@rustcorp.com.au> Mike Travis
2008-10-23 2:08 ` [PATCH 16/35] percpu: fix percpu accessors to potentially !cpu_possible() cpus " Mike Travis
2008-10-23 2:08 ` [PATCH 17/35] cpumask: make nr_cpu_ids the actual limit on bitmap size Mike Travis
2008-10-23 2:08 ` [PATCH 18/35] cpumask: use cpumask_bits() everywhere Mike Travis
2008-10-23 2:16 ` [PATCH 18/35] cpumask: use cpumask_bits() everywhere.-resubmit Mike Travis
2008-10-23 2:08 ` [PATCH 19/35] cpumask: cpumask_of(): cpumask_of_cpu() which returns a pointer. From: Rusty Russell <rusty@rustcorp.com.au> Mike Travis
2008-10-23 2:08 ` [PATCH 20/35] cpumask: for_each_cpu(): for_each_cpu_mask which takes a pointer " Mike Travis
2008-10-23 2:08 ` [PATCH 21/35] cpumask: cpumask_first/cpumask_next " Mike Travis
2008-10-23 2:08 ` [PATCH 22/35] cpumask: deprecate any_online_cpu() in favour of cpumask_any/cpumask_any_and " Mike Travis
2008-10-23 10:25 ` Ingo Molnar
2008-10-23 10:43 ` Ingo Molnar
2008-10-23 12:57 ` Mike Travis
2008-10-23 2:08 ` [PATCH 23/35] cpumask: cpumask_any_but() " Mike Travis
2008-10-23 11:00 ` Ingo Molnar
2008-10-23 2:08 ` [PATCH 24/35] cpumask: Deprecate CPUMASK_ALLOC etc in favor of cpumask_var_t. " Mike Travis
2008-10-23 2:08 ` [PATCH 25/35] cpumask: get rid of boutique sched.c allocations, use " Mike Travis
2008-10-23 2:08 ` [PATCH 26/35] cpumask: to_cpumask() " Mike Travis
2008-10-23 2:08 ` [PATCH 27/35] cpumask: accessors to manipulate possible/present/online/active maps " Mike Travis
2008-10-23 11:05 ` Ingo Molnar
2008-10-23 13:52 ` Mike Travis
2008-10-23 2:08 ` [PATCH 28/35] cpumask: CONFIG_BITS_ALL, CONFIG_BITS_NONE and CONFIG_BITS_CPU0 " Mike Travis
2008-10-23 2:08 ` [PATCH 29/35] cpumask: switch over to cpu_online/possible/active/present_mask " Mike Travis
2008-10-30 17:36 ` Tony Luck
2008-10-23 2:08 ` [PATCH 30/35] cpumask: cpu_all_mask and cpu_none_mask. " Mike Travis
2008-10-23 2:08 ` [PATCH 31/35] cpumask: reorder header to minimize separate #ifdefs " Mike Travis
2008-10-23 2:08 ` [PATCH 32/35] cpumask: debug options for cpumasks " Mike Travis
2008-10-23 2:08 ` [PATCH 33/35] cpumask: smp_call_function_many() " Mike Travis
2008-10-23 2:09 ` [PATCH 34/35] cpumask: Use accessors code. " Mike Travis
2008-10-23 5:34 ` Rusty Russell
2008-10-23 2:09 ` [PATCH 35/35] x86: clean up speedctep-centrino and reduce cpumask_t usage " Mike Travis
2008-10-23 5:36 ` Rusty Russell
2008-10-23 12:04 ` Ingo Molnar
2008-10-23 15:06 ` Rusty Russell
2008-10-23 15:10 ` Dave Jones
2008-10-27 16:23 ` Ingo Molnar
2008-10-23 12:03 ` [PATCH 00/35] cpumask: Replace cpumask_t with struct cpumask Ingo Molnar
2008-10-23 12:54 ` Mike Travis
2008-10-23 13:01 ` Ingo Molnar
2008-10-23 13:38 ` Mike Travis
2008-10-23 12:55 ` [bug] " Ingo Molnar
2008-10-23 12:57 ` Ingo Molnar
2008-10-23 13:00 ` Mike Travis
2008-10-23 14:20 ` [bug #2] " Ingo Molnar
2008-10-23 14:21 ` Ingo Molnar
2008-10-23 15:01 ` Rusty Russell
2008-10-23 15:20 ` Mike Travis
2008-10-23 16:09 ` Ingo Molnar
2008-10-23 22:29 ` Rusty Russell
2008-10-23 16:06 ` Ingo Molnar
2008-10-23 16:18 ` Mike Travis
2008-10-23 16:35 ` Ingo Molnar
2008-10-23 16:50 ` Mike Travis
2008-10-23 16:52 ` Ingo Molnar
2008-10-23 17:06 ` Mike Travis
2008-10-23 20:20 ` [PATCH 1/1]: cpumask: fix compiler errors/warnings Mike Travis
2008-10-23 14:22 ` [bug] Re: [PATCH 00/35] cpumask: Replace cpumask_t with struct cpumask Mike Travis
2008-10-23 14:24 ` Ingo Molnar
2008-10-23 14:28 ` Ingo Molnar
2008-10-23 14:32 ` Ingo Molnar
2008-10-23 23:01 ` Rusty Russell [this message]
2008-10-23 22:53 ` Rusty Russell
2008-10-27 16:20 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810241001.54175.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox