From: Theodore Tso <tytso@mit.edu>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Markus Trippelsdorf <markus@trippelsdorf.de>,
linux-kernel@vger.kernel.org, eugene@ibrix.com,
msnitzer@ibrix.com, akpm@linux-foundation.org
Subject: Re: ext3: fix ext3_dx_readdir hash collision handling - Regression
Date: Fri, 24 Oct 2008 16:44:47 -0400 [thread overview]
Message-ID: <20081024204446.GA12868@mit.edu> (raw)
In-Reply-To: <alpine.LFD.2.00.0810240853310.3287@nehalem.linux-foundation.org>
On Fri, Oct 24, 2008 at 09:08:26AM -0700, Linus Torvalds wrote:
>
> Hmm. Ted? I have not tried to revert that commit that Markus pinpointed
> (6a897cf447a83c9c3fd1b85a1e525c02d6eada7d: "ext3: fix ext3_dx_readdir hash
> collision handling"), but now that I look at that "git bug", I am getting
> pretty damn sure that it's exactly the same issue, and it's not a git bug
> at all.
Yep, I can replicate it now. It appears to only show up if you are
running with an x86_64 kernel. I normally run with an x86_32 kernel,
so I didn't notice the problem. The commit in question avoids
returning duplicate entries when there is a hash collision;
unfortunately, it seems to return duplicate entries for any large
directory if you are running on x86_64 (and possibly/probably other
64-bit platforms).
I'm working on it, and should hopefully have a fix for you soon. If
this is too annoying, you can revert it and I'll resubmit a fixed
version once I get a fix.
- Ted
next prev parent reply other threads:[~2008-10-25 11:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-22 9:32 ext3: fix ext3_dx_readdir hash collision handling - Regression Markus Trippelsdorf
2008-10-23 3:28 ` Theodore Tso
2008-10-23 6:37 ` Markus Trippelsdorf
2008-10-24 0:01 ` Theodore Tso
[not found] ` <20081024042851.GA2360@gentoox2.trippelsdorf.de>
2008-10-24 10:41 ` Theodore Tso
2008-10-24 16:08 ` Linus Torvalds
2008-10-24 20:44 ` Theodore Tso [this message]
2008-10-25 11:56 ` [PATCH] " Theodore Tso
2008-10-25 12:25 ` Markus Trippelsdorf
2008-10-25 21:15 ` Linus Torvalds
2008-10-26 2:39 ` [GIT PULL] " Theodore Tso
2008-10-26 2:42 ` [PATCH 1/2] ext3: Fix duplicate entries returned from getdents() system call Theodore Ts'o
2008-10-26 2:42 ` [PATCH 2/2] ext4: " Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081024204446.GA12868@mit.edu \
--to=tytso@mit.edu \
--cc=akpm@linux-foundation.org \
--cc=eugene@ibrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus@trippelsdorf.de \
--cc=msnitzer@ibrix.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox