From: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Arjan van de Ven <arjan@infradead.org>,
Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH v2][RFC] ftrace: function oprofiler
Date: Sun, 26 Oct 2008 07:25:56 -0700 [thread overview]
Message-ID: <20081026142556.GB6419@linux.vnet.ibm.com> (raw)
In-Reply-To: <alpine.DEB.1.10.0810260951500.20123@gandalf.stny.rr.com>
On Sun, Oct 26, 2008 at 09:58:01AM -0400, Steven Rostedt wrote:
>
> On Sun, 26 Oct 2008, Peter Zijlstra wrote:
>
> > On Sat, 2008-10-25 at 20:55 -0400, Steven Rostedt wrote:
> >
> > > This is a function profiler to count the number of times a function is hit.
> >
> > I have to ask, _why_?
> >
> > It seems like a nice enough gimmick, but is this information actually
> > useful?
>
> Well, it does let you know for sure which functions are the hottest paths.
> Perhaps you have a "slow path" function. This will show you how slow
> that slow path is. That is, how many times it is hit compared to the
> fast path.
And the ratio between the "hot path" and the "slow path" can be very
helpful in working out what sorts of optimizations can be used. Is a
give optimization that gains a factor of ten on the hot path and loses
a factor of 50 on the slow path a win?
Of course, you also need some estimate of the cost of the hot paths
and the slow paths.
Thanx, Paul
> With dynamic ftrace, you can also pick and choose which functions
> are to be counted.
>
> What is also nice about it (and something that I will use it for), is that
> it will show you the functions that will be hit the most during a trace.
> If you do not care about those functions, then you can easily filter them
> out for your trace.
>
> This patch is also a proof of concept. I'm sure others can think of more
> useful things to do by adding more stuff to this patch.
next prev parent reply other threads:[~2008-10-26 14:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-25 5:55 [PATCH][RFC] ftrace: function oprofiler Steven Rostedt
2008-10-25 10:51 ` Frédéric Weisbecker
2008-10-25 13:50 ` Steven Rostedt
2008-10-26 0:55 ` [PATCH v2][RFC] " Steven Rostedt
2008-10-26 10:35 ` Peter Zijlstra
2008-10-26 13:58 ` Steven Rostedt
2008-10-26 14:25 ` Paul E. McKenney [this message]
2008-10-26 14:20 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081026142556.GB6419@linux.vnet.ibm.com \
--to=paulmck@linux.vnet.ibm.com \
--cc=acme@ghostprotocols.net \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox