From: Christoph Hellwig <hch@infradead.org>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Matthew Wilcox <willy@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Rename DECLARE_MUTEX to DEFINE_SEMAPHORE
Date: Sun, 26 Oct 2008 12:41:18 -0400 [thread overview]
Message-ID: <20081026164118.GA19812@infradead.org> (raw)
In-Reply-To: <20081026120609.GA10728@joi>
On Sun, Oct 26, 2008 at 01:06:14PM +0100, Marcin Slusarz wrote:
> DECLARE_MUTEX is doubly misleading name (it actually _defines_ struct
> _semaphore_ initialized to 1) and it can be confused with DEFINE_MUTEX
> (which defines real struct mutex). Rename it.
NACK. It describes reasonably well what it does. Of course that's a
little confusing as we now have a specialized primitive to just do that.
If the name annoys you enough so that you want to get rid of it help
converting the remaining instances to struct mutex and DEFINE_MUTEX().
next prev parent reply other threads:[~2008-10-26 16:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-26 12:06 [PATCH] Rename DECLARE_MUTEX to DEFINE_SEMAPHORE Marcin Slusarz
2008-10-26 13:39 ` Peter Zijlstra
2008-10-26 14:11 ` Leon Woestenberg
2008-10-26 14:41 ` Peter Zijlstra
2008-10-26 15:20 ` Leon Woestenberg
2008-10-26 15:23 ` Marcin Slusarz
2008-10-26 16:41 ` Christoph Hellwig [this message]
2008-10-29 21:16 ` Marcin Slusarz
2008-10-29 21:22 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081026164118.GA19812@infradead.org \
--to=hch@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcin.slusarz@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=willy@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox