From: Al Viro <viro@ZenIV.linux.org.uk>
To: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
Cc: linux-kernel@vger.kernel.org, Linux-sh <linux-sh@vger.kernel.org>
Subject: Re: [PATCH] gdrom: Fix compile error
Date: Mon, 27 Oct 2008 04:08:15 +0000 [thread overview]
Message-ID: <20081027040814.GQ28946@ZenIV.linux.org.uk> (raw)
In-Reply-To: <29ab51dc0810261932n7580e87aua85103f8b1dcc5a5@mail.gmail.com>
On Mon, Oct 27, 2008 at 11:32:27AM +0900, Nobuhiro Iwamatsu wrote:
> Return value and argument of block_device_operations.release of gdrom
> was changed.
> This patch fix this problem.
Serves me right for snide comments about the benefits of compile-testing ;-)
ACKed-by: Al Viro <viro@zeniv.linux.org.uk>
FWIW, sh/sh64 is the only cross-toolchain needed for the kernel I hadn't
managed to build - 4.3.0 gcc manages to trigger internal error in sh64 as(1)
(2.18.50.0.6) and AFAICS the same should happen with any binutils up to
-HEAD (the minimal testcase is
.text
.LFB2:
.section .eh_frame,"a",@progbits
.quad .LFB2-.
and sh64 gcc4.3 routinely produces such things in its output). gcc trunk
seems to have arseloads of changes in gcc/config/sh and I hadn't got around
to attempting a backport ;-/
Are there any public sh/sh64 toolchains based on not too heavily hacked
gcc/binutils, ideally for more or less recent variants of both?
next prev parent reply other threads:[~2008-10-27 4:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 2:32 [PATCH] gdrom: Fix compile error Nobuhiro Iwamatsu
2008-10-27 4:08 ` Al Viro [this message]
2008-10-28 9:11 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081027040814.GQ28946@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=iwamatsu@nigauri.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox