From: Ingo Molnar <mingo@elte.hu>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linus <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: trace: fix printk warning for u64
Date: Mon, 27 Oct 2008 10:52:48 +0100 [thread overview]
Message-ID: <20081027095248.GA6969@elte.hu> (raw)
In-Reply-To: <20081027174328.084649ab.sfr@canb.auug.org.au>
* Stephen Rothwell <sfr@canb.auug.org.au> wrote:
> A powerpc ppc64_defconfig build produces these warnings:
>
> kernel/trace/ring_buffer.c: In function 'rb_add_time_stamp':
> kernel/trace/ring_buffer.c:969: warning: format '%llu' expects type 'long long unsigned int', but argument 2 has type 'u64'
> kernel/trace/ring_buffer.c:969: warning: format '%llu' expects type 'long long unsigned int', but argument 3 has type 'u64'
> kernel/trace/ring_buffer.c:969: warning: format '%llu' expects type 'long long unsigned int', but argument 4 has type 'u64'
>
> Just cast the u64s to unsigned long long like we do everywhere else.
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
applied to tip/tracing/urgent, thanks Stephen!
(btw., did the "unify u64 definitions across all platforms" project
get anywhere?)
Ingo
next prev parent reply other threads:[~2008-10-27 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-27 6:43 trace: fix printk warning for u64 Stephen Rothwell
2008-10-27 9:52 ` Ingo Molnar [this message]
2008-10-27 13:12 ` Stephen Rothwell
2008-10-28 5:06 ` Andrew Morton
2008-10-28 9:08 ` Ingo Molnar
2008-10-27 10:26 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081027095248.GA6969@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=sfr@canb.auug.org.au \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox