From: Bernhard Walle <bwalle@suse.de>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Thomas Mingarelli <thomas.mingarelli@hp.com>,
Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH] [WATCHDOG] Fix kdump when using hpwdt
Date: Mon, 27 Oct 2008 22:52:33 +0100 [thread overview]
Message-ID: <20081027225233.34758cda@kopernikus.site> (raw)
In-Reply-To: <20081027193053.GA2659@infomag.infomag.iguana.be>
Hi Wim,
* Wim Van Sebroeck [2008-10-27 20:30]:
> > -module_param(allow_kdump, int, 0);
> > +module_param(allow_kdump, int, 1);
> > MODULE_PARM_DESC(allow_kdump, "Start a kernel dump after NMI occurs");
>
> the syntax is: #define module_param(name, type, perm)
> perm sets the visibility in sysfs: 000 means it's not there,
> read bits mean it's readable, write bits mean it's writable.
>
> perm is not the default value for the integer but a file permission attribute.
Yeah, thanks for spotting that. I was a bit in hurry while creating the
patch ...
I'll come up with an updated patch with the suggestions from Vivek.
Probably tomorrow.
Regards,
Bernhard
--
Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development
next prev parent reply other threads:[~2008-10-27 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-26 14:59 [PATCH] [WATCHDOG] Fix kdump when using hpwdt Bernhard Walle
2008-10-27 19:30 ` Wim Van Sebroeck
2008-10-27 21:52 ` Bernhard Walle [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-11-23 13:15 Bernhard Walle
2008-11-25 14:27 ` Vivek Goyal
2008-11-25 14:32 ` Bernhard Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081027225233.34758cda@kopernikus.site \
--to=bwalle@suse.de \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.mingarelli@hp.com \
--cc=vgoyal@redhat.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox