From: Alexey Dobriyan <adobriyan@gmail.com>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: David Miller <davem@davemloft.net>,
johannes@sipsolutions.net, anders@anduras.de,
netdev@vger.kernel.org, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCHv3] printk: add %pM format specifier for MAC addresses
Date: Tue, 28 Oct 2008 02:31:53 +0300 [thread overview]
Message-ID: <20081027233153.GA11367@x200.localdomain> (raw)
In-Reply-To: <1225149254.6339.4.camel@brick>
On Mon, Oct 27, 2008 at 04:14:14PM -0700, Harvey Harrison wrote:
> On Mon, 2008-10-27 at 15:47 -0700, David Miller wrote:
> > From: Harvey Harrison <harvey.harrison@gmail.com>
> > Date: Mon, 27 Oct 2008 12:59:02 -0700
> >
> > > Add format specifiers for printing out six colon-separated bytes:
> > >
> > > MAC addresses (%pM):
> > > xx:xx:xx:xx:xx:xx
> > >
> > > %#pM is also supported and omits the colon separators.
> > >
> > > Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> >
> > Applied, thanks.
>
> Did you happen to have a preference with regard to the specifier for
> IPv6 addresses:
>
> I was thinking of using %pI6 to replace NIP6() and NIP6_FMT and using
> %#pI6 for NIP6_SEQFMT.
>
> On the IPv4 side, maybe use %pI4 for network endian NIPQUAD() and NIPQUAD_FMT
> and then %#pI4 for host-endian HIQUAD(), as displaying the IPv4 address without
> the periods isn't useful?
%#pI4 is horrible and %p4 and %p6 were cool.
next prev parent reply other threads:[~2008-10-27 23:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1224892008.3919.27.camel@johannes.berg>
[not found] ` <49035AF0.6040700@anduras.de>
[not found] ` <1225008096.3478.3.camel@johannes.berg>
[not found] ` <20081026.010329.11475786.davem@davemloft.net>
[not found] ` <1225009308.3478.22.camel@johannes.berg>
[not found] ` <1225009822.3478.30.camel@johannes.berg>
[not found] ` <1225047674.10060.10.camel@brick>
[not found] ` <1225049591.3746.0.camel@johannes.berg>
[not found] ` <1225049929.10060.11.camel@brick>
[not found] ` <1225050015.3746.2.camel@johannes.berg>
[not found] ` <1225060789.10060.13.camel@brick>
2008-10-27 0:31 ` [RFC PATCHv2] printk: add the %pM, %p4, %p6 format specifiers Harvey Harrison
2008-10-27 1:21 ` Frans Pop
2008-10-27 2:08 ` H. Peter Anvin
2008-10-27 6:59 ` Johannes Berg
2008-10-27 16:28 ` Harvey Harrison
2008-10-27 19:38 ` David Miller
2008-10-27 19:47 ` Johannes Berg
2008-10-27 19:59 ` [RFC PATCHv3] printk: add %pM format specifier for MAC addresses Harvey Harrison
2008-10-27 21:55 ` Joe Perches
2008-10-27 22:46 ` David Miller
2008-10-27 22:47 ` David Miller
2008-10-27 23:14 ` Harvey Harrison
2008-10-27 23:31 ` Alexey Dobriyan [this message]
2008-10-27 23:48 ` Joe Perches
2008-10-28 8:04 ` Johannes Berg
2008-10-27 23:55 ` David Miller
2008-10-28 0:05 ` Harvey Harrison
2008-10-28 0:22 ` Joe Perches
2008-10-28 8:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081027233153.GA11367@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=anders@anduras.de \
--cc=davem@davemloft.net \
--cc=harvey.harrison@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox