From: Ben Dooks <ben-linux@fluff.org>
To: Matthias Kaehlcke <matthias@kaehlcke.net>,
kernel@wantstofly.org, rmk@arm.linux.org.uk,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Subject: Re: [PATCH] ep93xx: fix OHCI DMA mask
Date: Tue, 28 Oct 2008 10:11:06 +0000 [thread overview]
Message-ID: <20081028101106.GB6099@fluff.org.uk> (raw)
In-Reply-To: <20081028081950.GA2930@traven>
On Tue, Oct 28, 2008 at 09:19:50AM +0100, Matthias Kaehlcke wrote:
> ep93xx: Fix OHCI DMA mask
>
> Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
Did this really have to go to so many people? akpm probably doesn't
need to know of this directly, Russell reads linux-arm-kernel so isn't
really a necessary CC: in this and you missed out the linux-usb list.
> --
>
> --- linux-2.6.27.org/arch/arm/mach-ep93xx/core.c 2008-10-10 00:13:53.000000000 +0200
> +++ linux-2.6.27/arch/arm/mach-ep93xx/core.c 2008-10-28 08:05:53.000000000 +0100
> @@ -26,6 +26,7 @@
> #include <linux/serial_core.h>
> #include <linux/device.h>
> #include <linux/mm.h>
> +#include <linux/dma-mapping.h>
> #include <linux/time.h>
> #include <linux/timex.h>
> #include <linux/delay.h>
> @@ -450,12 +451,13 @@
> },
> };
>
> +
> static struct platform_device ep93xx_ohci_device = {
> .name = "ep93xx-ohci",
> .id = -1,
> .dev = {
> - .dma_mask = (void *)0xffffffff,
> - .coherent_dma_mask = 0xffffffff,
> + .dma_mask = &ep93xx_ohci_device.dev.coherent_dma_mask,
> + .coherent_dma_mask = DMA_BIT_MASK(32),
> },
> .num_resources = ARRAY_SIZE(ep93xx_ohci_resources),
> .resource = ep93xx_ohci_resources,
>
> --
> Matthias Kaehlcke
> Embedded Linux Engineer
> Barcelona
>
> You can chain me, you can torture me, you can even
> destroy this body, but you will never imprison my mind
> (Mahatma Gandhi)
> .''`.
> using free software / Debian GNU/Linux | http://debian.org : :' :
> `. `'`
> gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
Ben (ben@fluff.org, http://www.fluff.org/)
'a smiley only costs 4 bytes'
next prev parent reply other threads:[~2008-10-28 10:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-28 8:19 [PATCH] ep93xx: fix OHCI DMA mask Matthias Kaehlcke
2008-10-28 10:11 ` Ben Dooks [this message]
2008-10-28 17:07 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081028101106.GB6099@fluff.org.uk \
--to=ben-linux@fluff.org \
--cc=akpm@linux-foundation.org \
--cc=kernel@wantstofly.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias@kaehlcke.net \
--cc=rmk@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox