From: Andrew Morton <akpm@linux-foundation.org>
To: David Newall <davidn@davidnewall.com>
Cc: jianjun@zeuux.org, cl@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fork.c: fix a problem of code style
Date: Tue, 28 Oct 2008 17:28:59 -0700 [thread overview]
Message-ID: <20081028172859.5986359b.akpm@linux-foundation.org> (raw)
In-Reply-To: <48FE0415.70700@davidnewall.com>
On Wed, 22 Oct 2008 03:02:21 +1030
David Newall <davidn@davidnewall.com> wrote:
> Jianjun Kong wrote:
> > - if(max_threads < 20)
> > + if (max_threads < 20)
>
> I thought we didn't bother with trivial style changes like this.
Yes, it's too small:
akpm:/usr/src/25> perl scripts/checkpatch.pl --file kernel/fork.c | grep total
total: 34 errors, 13 warnings, 1689 lines checked
We could merge thousands and thousand of one-line patches like this and
it's all very inefficient.
I'd consider larger patches which cleaned up whole subdirectories.
They're not much fun to maintain but we don't regret these things after
we've done them.
prev parent reply other threads:[~2008-10-29 0:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 14:16 [PATCH] fork.c: fix a problem of code style Jianjun Kong
2008-10-21 16:00 ` Christoph Lameter
2008-10-21 16:32 ` David Newall
2008-10-29 0:28 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081028172859.5986359b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=davidn@davidnewall.com \
--cc=jianjun@zeuux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox