Re: [PATCH] intel-agp: Avoid oops for G33 on 1MB stolen case

Brandon Philips
2008-10-29T05:24:20Z

On 14:52 Mon 20 Oct 2008, Arjan van de Ven wrote:
> On Tue, 21 Oct 2008 07:44:46 +1000
> Dave Airlie <airlied@redhat.com> wrote:
> > > + printk(KERN_WARNING PFX
> > > > + "Warning: G33 chipset
> > > > with 1MB"
> > > > + " allocated. Older X.org
> > > > Intel drivers"
> > > > + " will not work.\n");
> > > > + WARN_ON(1);
> > > > + }
> > > > gtt_entries = MB(1) - KB(size);
> > > > break;
> > > > case I855_GMCH_GMS_STOLEN_4M:
> > >
> > > Is the bug which this patch addresses present in the 2.6.27 kernel?
> > >
> >
> > I've been a bit wary about this patch, but on re-review I suppose it
> > should be fine. We'll just get WARN_ONs in places we don't really want
> > them, and I'm sure Arjan will come complaining about them from
> > kerneloops.

I figured it was better to be noisy than to have people complaining
about X.org being broken.

Should it be something other than a WARN?

> the patch is not so nice for this;
> the printk+WARN_ON() really should be using WARN() instead; that also
> allows me to filter these guys out easily if needed.

Ok. I will send a new patch in a moment using WARN().

Thanks,

Brandon