Re: [PATCH] intel-agp: Avoid oops for G33 on 1MB stolen case

Arjan van de Ven
2008-10-20T21:52:37Z

On Tue, 21 Oct 2008 07:44:46 +1000
Dave Airlie <airlied@redhat.com> wrote:
> > + printk(KERN_WARNING PFX
> > > + "Warning: G33 chipset
> > > with 1MB"
> > > + " allocated. Older X.org
> > > Intel drivers"
> > > + " will not work.\n");
> > > + WARN_ON(1);
> > > + }
> > > gtt_entries = MB(1) - KB(size);
> > > break;
> > > case I855_GMCH_GMS_STOLEN_4M:
> >
> > Is the bug which this patch addresses present in the 2.6.27 kernel?
> >
>
> I've been a bit wary about this patch, but on re-review I suppose it
> should be fine. We'll just get WARN_ONs in places we don't really want
> them, and I'm sure Arjan will come complaining about them from
> kerneloops.
>

the patch is not so nice for this;
the printk+WARN_ON() really should be using WARN() instead; that also
allows me to filter these guys out easily if needed.

--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org