From: Ingo Molnar <mingo@elte.hu>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: start annotating early ioremap pointers with __iomem
Date: Wed, 29 Oct 2008 08:05:37 +0100 [thread overview]
Message-ID: <20081029070537.GF7936@elte.hu> (raw)
In-Reply-To: <1225259164.20276.1.camel@brick>
* Harvey Harrison <harvey.harrison@gmail.com> wrote:
> As with regular ioremap, iounmap etc, annotate with __iomem.
>
> Fixes the following sparse warnings, will produce some new ones
> elsewhere in arch/x86 that will get worked out over time.
>
> arch/x86/mm/ioremap.c:402:9: warning: cast removes address space of expression
> arch/x86/mm/ioremap.c:406:10: warning: cast adds address space to expression (<asn:2>)
> arch/x86/mm/ioremap.c:782:19: warning: Using plain integer as NULL pointer
>
> Impact: some new sparse warnings in e820.c etc, but no functional change.
>
> Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
> ---
> arch/x86/include/asm/io.h | 6 +++---
> arch/x86/mm/ioremap.c | 22 +++++++++++-----------
> 2 files changed, 14 insertions(+), 14 deletions(-)
applied to tip/x86/urgent, thanks Harvey!
Ingo
prev parent reply other threads:[~2008-10-29 7:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 5:46 [PATCH] x86: start annotating early ioremap pointers with __iomem Harvey Harrison
2008-10-29 7:05 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081029070537.GF7936@elte.hu \
--to=mingo@elte.hu \
--cc=harvey.harrison@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox