From: Arjan van de Ven <arjan@infradead.org>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, morgan@kernel.org, serue@us.ibm.com
Subject: Re: [PATCH] Capabilities: BUG when an invalid capability is requested
Date: Wed, 29 Oct 2008 08:49:32 -0700 [thread overview]
Message-ID: <20081029084932.77de26fd@infradead.org> (raw)
In-Reply-To: <1225294932.23736.28.camel@localhost.localdomain>
On Wed, 29 Oct 2008 11:42:12 -0400
Eric Paris <eparis@redhat.com> wrote:
> If an invalid (large) capability is requested the capabilities system
> may panic as it is dereferencing an array of fixed (short) length.
> Its possible (and actually often happens) that the capability system
> accidentally stumbled into a valid memory region but it also regularly
> happens that it hits invalid memory and BUGs. If such an operation
> does get past cap_capable then the selinux system is sure to have
> problems as it already does a (simple) validity check and BUG. This
> is known to happen by the broken and buggy firegl driver.
>
> This patch cleanly checks all capable calls and BUG if a call is for
> an invalid capability. This will likely break the firegl driver for
> some situations, but it is the right thing to do. Garbage into a
> security system gets you killed/bugged
>
> Signed-off-by: Eric Paris <eparis@redhat.com>
>
Acked-by: Arjan van de Ven <arjan@linux.intel.com>
next prev parent reply other threads:[~2008-10-29 15:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-29 15:42 [PATCH] Capabilities: BUG when an invalid capability is requested Eric Paris
2008-10-29 15:49 ` Arjan van de Ven [this message]
2008-10-29 16:28 ` Serge E. Hallyn
2008-10-30 1:20 ` Andrew G. Morgan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081029084932.77de26fd@infradead.org \
--to=arjan@infradead.org \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=morgan@kernel.org \
--cc=serue@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox