Re: [PATCH] Rename DECLARE_MUTEX to DEFINE_SEMAPHORE

Christoph Hellwig
2008-10-26T16:41:32Z

On Sun, Oct 26, 2008 at 01:06:14PM +0100, Marcin Slusarz wrote:
> DECLARE_MUTEX is doubly misleading name (it actually _defines_ struct
> _semaphore_ initialized to 1) and it can be confused with DEFINE_MUTEX
> (which defines real struct mutex). Rename it.

NACK. It describes reasonably well what it does. Of course that's a
little confusing as we now have a specialized primitive to just do that.

If the name annoys you enough so that you want to get rid of it help
converting the remaining instances to struct mutex and DEFINE_MUTEX().