From: Ravikiran G Thirumalai <kiran@scalex86.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: venkatesh.pallipadi@intel.com, linux-kernel@vger.kernel.org,
tim@scalemp.com, shai@scalex86.org
Subject: [patch] x86: Fix /dev/mem mmap breakage when PAT is disabled
Date: Wed, 29 Oct 2008 19:02:03 -0700 [thread overview]
Message-ID: <20081030020203.GA12423@localdomain> (raw)
Fix mmap to /dev/mem when CONFIG_X86_PAT is off and CONFIG_STRICT_DEVMEM is
off
mmap to /dev/mem on kernel memory has been failing since the
introduction of PAT (CONFIG_STRICT_DEVMEM=n case). Seems like
the check to avoid cache aliasing with PAT is kicking in even
when PAT is disabled. The bug seems to have crept in 2.6.26.
This patch makes sure that mmap to regular kernel memory
succeeds if CONFIG_STRICT_DEVMEM=n and
PAT is disabled. The checks to avoid cache aliasing
still happens if PAT is enabled.
Signed-off-by: Ravikiran Thirumalai <kiran@scalex86.org>
Tested-by: Tim Sirianni <tim@scalemp.com>
Index: git.tip/arch/x86/mm/pat.c
===================================================================
--- git.tip.orig/arch/x86/mm/pat.c 2008-10-21 14:02:57.000000000 -0700
+++ git.tip/arch/x86/mm/pat.c 2008-10-29 13:19:47.000000000 -0800
@@ -481,6 +481,7 @@
return 1;
}
#else
+/* This check is needed to avoid cache aliasing when PAT is enabled */
static inline int range_is_allowed(unsigned long pfn, unsigned long size)
{
u64 from = ((u64)pfn) << PAGE_SHIFT;
@@ -508,7 +509,8 @@
unsigned long flags = -1;
int retval;
- if (!range_is_allowed(pfn, size))
+ /* Ensure cache aliasing does not occur if and only if PAT is on */
+ if (pat_enabled && !range_is_allowed(pfn, size))
return 0;
if (file->f_flags & O_SYNC) {
next reply other threads:[~2008-10-30 2:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-30 2:02 Ravikiran G Thirumalai [this message]
2008-10-30 18:29 ` [patch] x86: Fix /dev/mem mmap breakage when PAT is disabled Ingo Molnar
2008-10-30 20:59 ` Ravikiran G Thirumalai
2008-10-30 22:55 ` Ingo Molnar
2008-10-30 20:21 ` Arjan van de Ven
2008-10-30 21:21 ` Ravikiran G Thirumalai
2008-10-30 21:29 ` Arjan van de Ven
2008-10-30 21:54 ` Ravikiran G Thirumalai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081030020203.GA12423@localdomain \
--to=kiran@scalex86.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=shai@scalex86.org \
--cc=tim@scalemp.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox