Re: 2.6.28-rc2-mm1: Build failure on fs/quota.o

[Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>]

* Andrew Morton <akpm@linux-foundation.org> [2008-10-29 16:16:26]:

> On Wed, 29 Oct 2008 16:58:10 -0600
> Zan Lynx <zlynx@acm.org> wrote:
> 
> > Andrew Morton wrote:
> > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.28-rc2/2.6.28-rc2-mm1/
> > > 
> > > - Various architectures don't compile very well.  ia64, alpha, s390,
> > >   arm.  ftrace seems to be a particular culprit.
> > > 
> > > - But it seems to work OK on the six machines I ran it on.
> > > 
> > 
> > Here is the error:
> > 
> >   CC      fs/quota.o
> > fs/quota.c: In function ___generic_quotactl_valid___:
> > fs/quota.c:76: error: implicit declaration of function ___sb_has_quota_active___
> > make[1]: *** [fs/quota.o] Error 1
> > make: *** [fs] Error 2
> 
> Thanks.

Thanks, the patch fixes the build failure.

> 
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> fs/quota.c: In function `generic_quotactl_valid':
> fs/quota.c:76: error: implicit declaration of function `sb_has_quota_active'
> 
> Cc: Jan Kara <jack@suse.cz>
> Reported-by: Zan Lynx <zlynx@acm.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
  Tested-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
> ---
> 
>  include/linux/quotaops.h |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff -puN include/linux/quotaops.h~quota-permit-separately-enabling-quota-accounting-and-enforcing-limits-fix include/linux/quotaops.h
> --- a/include/linux/quotaops.h~quota-permit-separately-enabling-quota-accounting-and-enforcing-limits-fix
> +++ a/include/linux/quotaops.h
> @@ -257,6 +257,11 @@ static inline int sb_any_quota_loaded(st
>  	return 0;
>  }
> 
> +static inline int sb_has_quota_active(struct super_block *sb, int type)
> +{
> +	return 0;
> +}
> +
>  static inline int sb_any_quota_active(struct super_block *sb)
>  {
>  	return 0;
> _
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
Thanks & Regards,
Kamalesh Babulal,
Linux Technology Center,
IBM, ISTL.