Re: [PATCH 0/2] ftrace: handle NMIs safely

Ingo Molnar
2008-10-30T22:26:36Z

* Steven Rostedt <rostedt@goodmis.org> wrote:

>
> On Thu, 30 Oct 2008, Ingo Molnar wrote:
>
> >
> > * Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > The robustness of ftrace has been the focus of the code modification
> > > in 2.6.28. There is one remaining issue that needed to be addressed.
> > > This was the case of NMIs.
> >
> > applied to tip/tracing/nmisafe, thanks Steve!
> >
> > this looks a lot nicer approach than either putting some sort of lock
> > into NMI context (yuck) or the disabling of NMIs (not really possible
> > in a generic way architecturally).
> >
> > the impact is quite non-trivial, so i dont think this is v2.6.28
> > material.
>
> Ingo,
>
> Do you want me to send patches on top of these to address Andrew's
> comements? Or do you want me to resend these with the updates.
>
> I prefer to send patches on top, that way Andrew can make sure I did
> his changes correctly ;-)

yeah, please do it that way. It's a separate topic so we can fold them
back if they are also bugfixes. (and they are all cleanliness related
and i wanted to see the stability impact ASAP)

Ingo