Re: [PATCH 01/11] ftrace: handle generic arch calls

Adrian Bunk
2008-10-29T20:33:00Z

On Wed, Oct 29, 2008 at 04:23:34PM -0400, Steven Rostedt wrote:
>
> On Wed, 29 Oct 2008, Adrian Bunk wrote:
> > > >
> > > > Since x86 is the ambiguous case, I made it the one that would be converted
> > > > to i386 or x86_64 since those could be passed in directly.
> > > The trick is usually to replace use of ARCH with SRCARCH.
> >
> > That won't help - what he wants to know is whether he's on 32bit or
> > on 64bit.
>
> I will still get the "bits" parameter.

Ah, I didn't get this bit from your email.

> The issue that we are talking about
> here is that I have this ugly if statement that deals with the fact that
> we can get "x86", "x86_64" or "i386" passed in as the ARCH. I'm guessing
> if we switch ARCH to SRCARCH then we can just test against x86 and bits?

Yes.

And as a bonus you will automatically get the correct output when you'll
add support for UML.

> -- Steve

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed