Re: [PATCH 03/11] ftrace: return error on failed modified text.

Andrew Morton
2008-10-22T18:58:43Z

On Wed, 22 Oct 2008 14:43:16 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> Return -1 on failed modified text.
>

changelog fails to explain the reason for the change.

> + if (__copy_to_user_inatomic((char __user *)ip, new_code,
> + MCOUNT_INSN_SIZE))
> + return -1;

why not -EFAULT?