Re: [PATCH 03/11] ftrace: return error on failed modified text.

Steven Rostedt
2008-10-22T19:04:17Z

On Wed, 22 Oct 2008, Andrew Morton wrote:

> On Wed, 22 Oct 2008 14:43:16 -0400
> Steven Rostedt <rostedt@goodmis.org> wrote:
>
> > Return -1 on failed modified text.
> >
>
> changelog fails to explain the reason for the change.
>
> > + if (__copy_to_user_inatomic((char __user *)ip, new_code,
> > + MCOUNT_INSN_SIZE))
> > + return -1;
>
> why not -EFAULT?

Indeed, why not. I'll update it in v2.

-- Steve