public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: merging other repos into linux-2.6
Date: Thu, 30 Oct 2008 20:13:57 -0700	[thread overview]
Message-ID: <20081031031357.GA20944@kroah.com> (raw)
In-Reply-To: <alpine.LFD.2.00.0810301619260.21084@nehalem.linux-foundation.org>

On Thu, Oct 30, 2008 at 04:28:46PM -0700, Linus Torvalds wrote:
> 
> 
> On Thu, 30 Oct 2008, Greg KH wrote:
> > 
> > But as for the 'bisectability' at one point in the merge, you will be
> > adding a stand-alone driver into the kernel itself.  So for anyone
> > traversing down that path, all you would be building would be the driver
> > itself, the whole rest of the kernel is "gone".
> 
> Right. This was exactly what happened initially in the btrfs thing. And it 
> was horrid.
> 
> It was horrid because it was totally unexpected for users, and causes huge 
> churn and confusion when trying to check out a totally different directory 
> layout (and git won't remove the old *.o files, so trust me, it _will_ be 
> confusing).

I agree, I don't want this to happen.

> What I got Chris Mason to do was to run
> 
> 	git filter-branch --index odd-script-goes-here
> 
> with that odd script looking something like:
> 
> >       #!/bin/sh
> >       exists=$(git ls-files fs/btrfs/)
> >       [ -z "$exists" ] &&
> >               git ls-files --stage |
> >               awk -F '\t' '{ print "0 0000000000000000000000000000000000000000\t" $2 "\n" $1 "\tfs/btrfs/" $2 }' |
> >               git update-index --index-info
> 
> which basically does a directory rename in the branch (obviously, in this 
> case into fs/btrfs, which is not what _you_ want). That way, at least the 
> directory structure of the tree you merge has the same layout, and you 
> don't get _that_ particular directory jumping back and forth.
> 
> Chris also merged in the history at the 2.6.26 tree (I think), so that 
> while his original history had had just a stand-alone btrfs build, the end 
> result was actually *totally* bisectable. Again, you should ask him about 
> any other scripts he ran.

Ok, this seems a lot more reasonable, and doable.

But then I took a long look at the cvs commit logs.

And you are right, they are crap, and pointless to have here.

So, thanks a lot for showing me how to do this properly, in the future I
might do this (actually, for one wireless driver, I might do this now,
as it was always developed in git), but for the comedi code, I'll just
use the "normal" method of adding drivers one at a time, with none of
the crazy past history sucked in as it doesn't add any value.

thanks,

greg k-h

  reply	other threads:[~2008-10-31  3:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30  5:49 merging other repos into linux-2.6 Greg KH
2008-10-30 17:17 ` Stefan Richter
2008-10-30 19:04 ` Linus Torvalds
2008-10-30 21:52   ` Dave Kleikamp
2008-10-30 23:19     ` Linus Torvalds
2008-10-30 21:57   ` Greg KH
2008-10-30 23:28     ` Linus Torvalds
2008-10-31  3:13       ` Greg KH [this message]
2008-10-31  1:34 ` J.R. Mauro
2008-10-31  1:47   ` Linus Torvalds
2008-10-31  2:38     ` J.R. Mauro
2008-10-31  3:31       ` Theodore Tso
2008-10-31  4:08       ` Kyle Moffett
2008-10-31 12:57         ` J.R. Mauro
2008-10-31 14:22           ` Kyle Moffett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081031031357.GA20944@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox