public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Kay Sievers <kay.sievers@vrfy.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: driver core: struct device - replace bus_id with dev_name(), dev_set_name()
Date: Fri, 31 Oct 2008 11:05:22 -0700	[thread overview]
Message-ID: <20081031180522.GA30195@kroah.com> (raw)
In-Reply-To: <ac3eb2510810311057j6069aa99j4f46c6f563b5740@mail.gmail.com>

On Fri, Oct 31, 2008 at 06:57:52PM +0100, Kay Sievers wrote:
> On Fri, Oct 31, 2008 at 18:02, Greg KH <greg@kroah.com> wrote:
> > On Thu, Oct 30, 2008 at 01:36:48AM +0100, Kay Sievers wrote: index 5437ac0..c9c214d 100644
> >> --- a/include/linux/kobject.h
> >> +++ b/include/linux/kobject.h
> >> @@ -72,6 +72,8 @@ struct kobject {
> >>
> >>  extern int kobject_set_name(struct kobject *kobj, const char *name, ...)
> >>                           __attribute__((format(printf, 2, 3)));
> >> +extern int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
> >> +                               va_list vargs);
> >>
> >>  static inline const char *kobject_name(const struct kobject *kobj)
> >>  {
> >> diff --git a/lib/kobject.c b/lib/kobject.c
> >> index 0487d1f..a6dec32 100644
> >> --- a/lib/kobject.c
> >> +++ b/lib/kobject.c
> >> @@ -212,7 +212,7 @@ static int kobject_add_internal(struct kobject *kobj)
> >>   * @fmt: format string used to build the name
> >>   * @vargs: vargs to format the string.
> >>   */
> >> -static int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
> >> +int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
> >>                                 va_list vargs)
> >>  {
> >>       const char *old_name = kobj->name;
> >>
> >
> > I cut this part out of this patch, as it's not needed here, and applied
> > the rest.
> 
> Ah, yeah, this hunk belongs to "driver core: get rid of bus_id" which
> I sent you, and which should be locally in your tree to catch new
> instances of bus_id in staging. We will push to -next when we got most
> of it converted and want to fix the remaining pieces.

Ok, that makes more sense.

Care to respin that patch with these chunks added to it so that it will
work properly?

thanks,

greg k-h

  reply	other threads:[~2008-10-31 18:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-30  0:36 driver core: struct device - replace bus_id with dev_name(), dev_set_name() Kay Sievers
2008-10-31 17:02 ` Greg KH
2008-10-31 17:57   ` Kay Sievers
2008-10-31 18:05     ` Greg KH [this message]
2008-10-31 18:16       ` Kay Sievers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081031180522.GA30195@kroah.com \
    --to=greg@kroah.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox