From: Andrey Borzenkov <arvidjaar@mail.ru>
To: mingo@redhat.com, avi@qumranet.com
Cc: Andrew Morton <akpm@osdl.org>, "Rafael J. Wysocki" <rjw@sisk.pl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] Use BIOS reboot on Toshiba Portege 4000
Date: Fri, 31 Oct 2008 21:18:43 +0300 [thread overview]
Message-ID: <200810312118.45368.arvidjaar@mail.ru> (raw)
[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]
Subject: [PATCH] Use BIOS reboot on Toshiba Portege 4000
From: Andrey Borzenkov <arvidjaar@mail.ru>
After commit c7ffa6c26277b403920e2255d10df849bd613380 which defaults
to reboot via ACPI keyboard is dead on Toshiba Portege 4000 upon reboot.
Power off is required to revive it again. Add DMI entry to force BIOS
reboot method as it was before.
Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>
---
This fixes regression in 2.6.28. Commit log states:
Triple-fault and keyboard reset may assert INIT instead of RESET; however
INIT is blocked when Intel VT is enabled. This leads to a partially reset
machine when invoking emergency_restart via sysrq-b: the processor is still
working but other parts of the system are dead.
I wonder if we better check for VT bit instead of using DMI entries?
arch/x86/kernel/reboot.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c
index f4c93f1..f9b28b3 100644
--- a/arch/x86/kernel/reboot.c
+++ b/arch/x86/kernel/reboot.c
@@ -197,6 +197,14 @@ static struct dmi_system_id __initdata reboot_dmi_table[] = {
DMI_MATCH(DMI_PRODUCT_NAME, "HP Compaq"),
},
},
+ { /* Handle problems with rebooting on Toshiba Portege 4000 */
+ .callback = set_bios_reboot,
+ .ident = "Toshiba Portege 4000",
+ .matches = {
+ DMI_MATCH(DMI_SYS_VENDOR, "TOSHIBA"),
+ DMI_MATCH(DMI_PRODUCT_NAME, "PORTEGE 4000"),
+ },
+ },
{ }
};
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next reply other threads:[~2008-10-31 18:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-31 18:18 Andrey Borzenkov [this message]
2008-11-03 9:08 ` [PATCH] Use BIOS reboot on Toshiba Portege 4000 Ingo Molnar
2008-11-03 10:02 ` Avi Kivity
2008-11-03 10:04 ` Ingo Molnar
2008-11-03 13:33 ` Eduardo Habkost
2008-11-03 14:41 ` Avi Kivity
2008-11-03 16:13 ` Eric W. Biederman
2008-11-03 17:01 ` Eduardo Habkost
2008-11-04 10:47 ` Avi Kivity
2008-11-04 11:22 ` Eric W. Biederman
2008-11-04 11:57 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200810312118.45368.arvidjaar@mail.ru \
--to=arvidjaar@mail.ru \
--cc=akpm@osdl.org \
--cc=avi@qumranet.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox