public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Marek Vasut <marek.vasut@gmail.com>
To: Dmitry <dbaryshkov@gmail.com>
Cc: linux-kernel@vger.kernel.org, cbou@mail.ru,
	"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH] power_supply: change the way how wm97xx-bat driver is registered
Date: Mon, 3 Nov 2008 00:41:25 +0100	[thread overview]
Message-ID: <200811030041.25995.marek.vasut@gmail.com> (raw)
In-Reply-To: <bc64b4640811021236k1518cf8awc36da8bcda259da@mail.gmail.com>

On Sunday 02 of November 2008 21:36:58 Dmitry wrote:
> 2008/10/29 Dmitry Baryshkov <dbaryshkov@gmail.com>:
> > Do register the driver from wm97xx_bat_set_pdata instead of module init.
> > This has several positive outcome points:
> > 1) This driver for wm97xx-battery is now registered on demand, thus
> > allowing other driver (e.g. tosa-battery) to claim the battery.
> > 2) After dropping __init from wm97xx_bat_set_pdata(), the wm97xx_bat
> > driver can be correctly built as a module. Then one can request it and
> > set the battery data.
> >
> > Signed-off-by: Dmitry Baryshkov <dbaryshkov@gmail.com>
> > Cc: Marek Vasut <marek.vasut@gmail.com>
> > ---
> >  drivers/power/Kconfig          |    4 ++--
> >  drivers/power/wm97xx_battery.c |   12 +++++-------
> >  include/linux/wm97xx_batt.h    |    7 +++++--
> >  3 files changed, 12 insertions(+), 11 deletions(-)
>
> What about this patch?

Im sure you know what you are doing. I cant test it right now though, since I 
have load of university work to do, sorry.

  reply	other threads:[~2008-11-02 23:36 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-29  9:04 [PATCH] power_supply: only register tosa_battery driver on tosa Dmitry Baryshkov
2008-10-29  9:04 ` [PATCH] power_supply: change the way how wm97xx-bat driver is registered Dmitry Baryshkov
2008-11-02 20:36   ` Dmitry
2008-11-02 23:41     ` Marek Vasut [this message]
2008-11-03 15:11   ` Anton Vorontsov
2008-11-03 16:54     ` Jonathan Cameron
2008-11-03 17:21       ` Anton Vorontsov
2008-11-03 18:29     ` Dmitry Baryshkov
2008-11-03 19:34       ` Anton Vorontsov
2008-11-02 20:36 ` [PATCH] power_supply: only register tosa_battery driver on tosa Dmitry
2008-11-03 14:55   ` Anton Vorontsov
2008-11-03 16:20     ` Dmitry
2008-11-03 16:25       ` Anton Vorontsov
2008-11-03 16:41         ` Dmitry
2008-11-03 16:58           ` Anton Vorontsov
2008-11-03 17:09             ` Dmitry
2008-11-03 17:32               ` Anton Vorontsov
2008-11-03 18:14                 ` Dmitry
2008-11-03 17:41           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200811030041.25995.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=cbou@mail.ru \
    --cc=dbaryshkov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox