public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrey Borzenkov <arvidjaar@mail.ru>, Avi Kivity <avi@qumranet.com>
Cc: mingo@redhat.com, avi@qumranet.com, Andrew Morton <akpm@osdl.org>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Use BIOS reboot on Toshiba Portege 4000
Date: Mon, 3 Nov 2008 10:08:43 +0100	[thread overview]
Message-ID: <20081103090843.GI11730@elte.hu> (raw)
In-Reply-To: <200810312118.45368.arvidjaar@mail.ru>


* Andrey Borzenkov <arvidjaar@mail.ru> wrote:

> Subject: [PATCH] Use BIOS reboot on Toshiba Portege 4000
> 
> From: Andrey Borzenkov <arvidjaar@mail.ru>
> 
> After commit c7ffa6c26277b403920e2255d10df849bd613380 which defaults
> to reboot via ACPI keyboard is dead on Toshiba Portege 4000 upon reboot.
> Power off is required to revive it again. Add DMI entry to force BIOS
> reboot method as it was before.
> 
> Signed-off-by: Andrey Borzenkov <arvidjaar@mail.ru>

Avi, i expect more boxes to be affected by this bug, and the DMI 
solution just does not scale.

So could we please disable VMX from the emergency-shutdown code 
instead of twiddling with the reboot method?

Something like this might work as well: iff VMX is enabled, we just do 
smp_send_stop() (instead of skipping it) which should take care of 
this.

	Ingo

  reply	other threads:[~2008-11-03  9:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-31 18:18 [PATCH] Use BIOS reboot on Toshiba Portege 4000 Andrey Borzenkov
2008-11-03  9:08 ` Ingo Molnar [this message]
2008-11-03 10:02   ` Avi Kivity
2008-11-03 10:04     ` Ingo Molnar
2008-11-03 13:33     ` Eduardo Habkost
2008-11-03 14:41       ` Avi Kivity
2008-11-03 16:13         ` Eric W. Biederman
2008-11-03 17:01           ` Eduardo Habkost
2008-11-04 10:47           ` Avi Kivity
2008-11-04 11:22             ` Eric W. Biederman
2008-11-04 11:57               ` Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081103090843.GI11730@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=arvidjaar@mail.ru \
    --cc=avi@qumranet.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox