Re: [PATCH] power_supply: only register tosa_battery driver on tosa

Anton Vorontsov
2008-11-03T17:32:47Z

On Mon, Nov 03, 2008 at 08:09:14PM +0300, Dmitry wrote:
[...]
> >> Yup.
> >> I see few ways to resolve this:
> >> * write better wm97xx interface. Dunno if that is feasible or possible.
> >> One of the possible solutions is to pass battery and ts device names
> >> and data from within board data via ac97 layer to wm97xx-core. This
> >> will provide several benefits (e.g. then we can drop lots of parameters
> >> from wm97xx-core, which are really board parameters).
> >
> > That would be great indeed. But for now, just don't compile the two
> > drivers on the tosa platform. No need for machine_is_*() hacks...
>
> That is a bit strange requirement. During several past months there was
> a lot of efforts put into supporting multi-machine PXA kernel images.

Yes, I know this.

But you're implementing hacks instead of fixing the problem.

Btw, you inserted the machine_is() into the tosa driver, but
wm97xx driver registers unconditionally. That could be a problem
when wm97xx loads first, and then you try to load the tosa_battery
module on tosa machine.

Let's insert machine_is() hack into the wm97xx driver as well?

--
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2