From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755362AbYKDTry (ORCPT ); Tue, 4 Nov 2008 14:47:54 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752771AbYKDTrp (ORCPT ); Tue, 4 Nov 2008 14:47:45 -0500 Received: from mx2.redhat.com ([66.187.237.31]:43348 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbYKDTro (ORCPT ); Tue, 4 Nov 2008 14:47:44 -0500 Date: Tue, 4 Nov 2008 14:46:52 -0500 From: Jeff Layton To: Trond Myklebust Cc: Andrew Morton , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org Subject: Re: [PATCH] lockd: convert reclaimer thread to kthread interface Message-ID: <20081104144652.18d2910d@tleilax.poochiereds.net> In-Reply-To: <1225826781.30407.11.camel@heimdal.trondhjem.org> References: <1225278945-15407-1-git-send-email-jlayton@redhat.com> <20081103131215.75a83236.akpm@linux-foundation.org> <20081103191924.16528bfd@tleilax.poochiereds.net> <1225802508.19864.2.camel@heimdal.trondhjem.org> <20081104134235.0382c873@tleilax.poochiereds.net> <1225826781.30407.11.camel@heimdal.trondhjem.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 04 Nov 2008 14:26:21 -0500 Trond Myklebust wrote: > On Tue, 2008-11-04 at 13:42 -0500, Jeff Layton wrote: > > While we're on the subject of signals... > > > > Do you have any thoughts/objections to just making the reclaimer thread > > ignore them altogether? That would simplify the code a bit. > > How does the administrator then get out of the situation where the > server dies (permanently) in the middle of a reclaim? > Erm...Reboot? :) Ok, I'm convinced. I suppose that's a good enough argument for continuing to allow SIGKILL. I guess the only change we need to make to this patch for now is to remove the "memory leak" comment (unless there is a leak and I'm just not seeing it). -- Jeff Layton