From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Alan Jenkins <alan-jenkins@tuffmail.co.uk>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Add option to passively listen for PCIE hotplug events
Date: Tue, 4 Nov 2008 15:57:22 +0000 [thread overview]
Message-ID: <20081104155722.GA23314@srcf.ucam.org> (raw)
In-Reply-To: <49106DD7.9010307@tuffmail.co.uk>
On Tue, Nov 04, 2008 at 03:44:23PM +0000, Alan Jenkins wrote:
> I instrumented all the delays I could find. hpc_check_lnk_status() was
> the only one that came up. 1000ms delay per call, and I get 6 such delays.
Ok, which is getting called from pciehp_enable_slot(). I'm not quite
clear on why this is being called 6 times - any chance you can put a
dump_stack() in there? Some are probably directly from the resume code.
This confuses me a little, since there's a check for whether there's a
card in the slot first. If that fails, pciehp_enable_slot() isn't
called. If it succeeds, pciehp_enable_slot checks whether the slot is
already powered up. If it is, it bails before doing the link setup. So
something funny is going on here, since on the Eee I'd expect those
slots to either be empty or already powered up.
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2008-11-04 15:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bspwK-420-11@gated-at.bofh.it>
[not found] ` <bujnh-2fr-5@gated-at.bofh.it>
[not found] ` <bujwT-2Ew-5@gated-at.bofh.it>
[not found] ` <buml1-6du-3@gated-at.bofh.it>
2008-11-04 11:29 ` Add option to passively listen for PCIE hotplug events Alan Jenkins
2008-11-04 12:47 ` Matthew Garrett
2008-11-04 13:32 ` Matthew Garrett
2008-11-04 14:26 ` Alan Jenkins
2008-11-04 14:33 ` Matthew Garrett
2008-11-04 15:01 ` Alan Jenkins
2008-11-04 15:11 ` Matthew Garrett
2008-11-04 15:44 ` Alan Jenkins
2008-11-04 15:57 ` Matthew Garrett [this message]
2008-11-04 16:22 ` Alan Jenkins
2008-11-09 16:08 ` Alan Jenkins
2008-11-12 23:34 ` Matthew Garrett
2008-11-14 16:16 ` Matthew Garrett
2008-11-14 17:07 ` Alan Jenkins
2008-11-14 17:12 ` Matthew Garrett
2008-11-14 17:27 ` Alan Jenkins
2008-11-14 17:35 ` Matthew Garrett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081104155722.GA23314@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=alan-jenkins@tuffmail.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox