From: Frans Pop <elendil@planet.nl>
To: David Brownell <david-b@pacbell.net>
Cc: linux-kernel@vger.kernel.org,
Dominik Brodowski <linux@dominikbrodowski.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] rtc-cmos: Fix boot log message
Date: Tue, 4 Nov 2008 17:42:43 +0100 [thread overview]
Message-ID: <200811041742.45285.elendil@planet.nl> (raw)
In-Reply-To: <200811031506.42247.david-b@pacbell.net>
On Tuesday 04 November 2008, David Brownell wrote:
> On Monday 03 November 2008, Frans Pop wrote:
> > Alternative would be to change the following line at 808:
> > is_hpet_enabled() ? ", hpet irqs" : "");
> > to:
> > is_hpet_enabled() ? "hpet" : "<sensible
> > value>");
>
> The intent was "hpet irqs" vs "native IRQs" (typical PC options)
> vs "no irqs" (e.g. on SPARCs).
>
> I think fixes got trashed when the patch queue got corrupted
> by some queue-jumping ... see the patch in
>
> http://bugzilla.kernel.org/show_bug.cgi?id=11153
>
> which was broken by a474aaedac99ba86e28ef6c912a7647c482db6dd,
> and has appropriately sane messaging.
AFAICT that patch is still pending, which means that the patch I proposed
should be good and fix the "regression".
When your original patch is then updated against git head and resubmitted,
things should still end up as you intended.
Cheers,
FJP
next prev parent reply other threads:[~2008-11-04 16:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-03 18:42 Some minor ugliness in changed boot logging Frans Pop
2008-11-03 18:52 ` [PATCH] rtc-cmos: Fix boot log message Frans Pop
2008-11-03 23:06 ` David Brownell
2008-11-04 16:42 ` Frans Pop [this message]
2008-11-07 13:19 ` [PATCH] pcmcia: ensure correct logging in do_io_probe Frans Pop
2008-11-07 13:35 ` [PATCH] pcmcia: minor logging improvement on card detection Frans Pop
2008-11-09 20:43 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200811041742.45285.elendil@planet.nl \
--to=elendil@planet.nl \
--cc=akpm@linux-foundation.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox