From: Oleg Nesterov <oleg@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@elte.hu>
Cc: adobriyan@gmail.com, Doug Chapman <doug.chapman@hp.com>,
Peter Zijlstra <peterz@infradead.org>,
Roland McGrath <roland@redhat.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] account_group_exec_runtime: fix the racy usage of ->signal
Date: Fri, 7 Nov 2008 17:52:38 +0100 [thread overview]
Message-ID: <20081107165238.GA23055@redhat.com> (raw)
Compile tested.
Unlike other similar routines, account_group_exec_runtime() could be
called "implicitly" after exit_notify(). This means we can race with
the parent doing release_task(), we can't just check ->signal != NULL.
Take ->siglock to make sure ->signal can't go away.
This is the minimal fix, with this patch we don't need need get/put cpu,
and I think we should uninline this function.
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
--- K-28/kernel/sched_stats.h~A_G_E_R_FIX 2008-11-07 17:32:02.000000000 +0100
+++ K-28/kernel/sched_stats.h 2008-11-07 17:44:39.000000000 +0100
@@ -351,10 +351,12 @@ static inline void account_group_exec_ru
unsigned long long ns)
{
struct signal_struct *sig;
+ unsigned long flags;
- sig = tsk->signal;
- if (unlikely(!sig))
+ if (unlikely(!lock_task_sighand(tsk, &flags)))
return;
+
+ sig = tsk->signal;
if (sig->cputime.totals) {
struct task_cputime *times;
@@ -362,4 +364,6 @@ static inline void account_group_exec_ru
times->sum_exec_runtime += ns;
put_cpu_no_resched();
}
+
+ unlock_task_sighand(tsk, &flags);
}
next reply other threads:[~2008-11-07 15:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-07 16:52 Oleg Nesterov [this message]
2008-11-07 16:21 ` [PATCH] account_group_exec_runtime: fix the racy usage of ->signal Ingo Molnar
2008-11-07 16:58 ` Doug Chapman
2008-11-07 18:42 ` Oleg Nesterov
2008-11-07 17:40 ` Oleg Nesterov
2008-11-08 9:28 ` Ingo Molnar
2008-11-10 13:04 ` Oleg Nesterov
2008-11-10 12:13 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081107165238.GA23055@redhat.com \
--to=oleg@redhat.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=doug.chapman@hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox