From: Samuel Ortiz <sameo@openedhand.com>
To: Mike Rapoport <mike@compulab.co.il>
Cc: linux-kernel@vger.kernel.org, eric.y.miao@gmail.com
Subject: Re: [PATCH] mfd: da903x: fix event masking for da9030
Date: Sat, 8 Nov 2008 01:31:26 +0100 [thread overview]
Message-ID: <20081108003126.GA5993@sortiz.org> (raw)
In-Reply-To: <1225970631-15451-1-git-send-email-mike@compulab.co.il>
On Thu, Nov 06, 2008 at 01:23:51PM +0200, Mike Rapoport wrote:
>
> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
Thanks Mike, applied to my for-linus branch.
Cheers,
Samuel.
> ---
> drivers/mfd/da903x.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
> index b57326a..0b5bd85 100644
> --- a/drivers/mfd/da903x.c
> +++ b/drivers/mfd/da903x.c
> @@ -267,7 +267,7 @@ static int da9030_mask_events(struct da903x_chip *chip, unsigned int events)
> {
> uint8_t v[3];
>
> - chip->events_mask &= ~events;
> + chip->events_mask |= events;
>
> v[0] = (chip->events_mask & 0xff);
> v[1] = (chip->events_mask >> 8) & 0xff;
> --
> 1.5.6.4
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2008-11-08 0:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-06 11:23 [PATCH] mfd: da903x: fix event masking for da9030 Mike Rapoport
2008-11-07 12:58 ` Eric Miao
2008-11-08 0:31 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081108003126.GA5993@sortiz.org \
--to=sameo@openedhand.com \
--cc=eric.y.miao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mike@compulab.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox