Re: [PATCH 1/2] Staging: only build the tree if we really want to

Greg KH
2008-11-11T06:35:40Z

On Sat, Nov 08, 2008 at 08:31:41PM +0100, Stefan Richter wrote:
> Greg KH wrote:
> > On Sat, Nov 08, 2008 at 04:59:37PM +0100, Stefan Richter wrote:
> >>> -endif # STAGING
> >>> +endif # !STAGING_EXCLUDE_BUILD
> >> Which purpose is the STAGING kconfig variable serving after this?
> >
> > Sitting there and looking pretty :)
> >
> >> It controls the visibility of the menu, but switching it off won't
> >> switch off the staging drivers if they were previously enabled, would
> >> it?
> >
> > Try it and look in wonder :)
> >
> > If something affects the visibility of the menu for those config
> > options, it controls if those options can be enabled or not.
>
> Right. But if you had STAGING on, STAGING_EXCLUDE_BUILD off, and for
> example ET131X on, then ET131X will still be on if you switch STAGING
> off and save the configuration.

I think Linus fixed this, look at 2.6.28-rc4.

thanks,

greg k-h