From: Evgeniy Polyakov <zbr@ioremap.net>
To: linux-kernel@vger.kernel.org
Cc: Robert Love <rlove@rlove.org>, Michael Kerrisk <mtk.manpages@gmail.com>
Subject: [1/1] Use pid in inotify events.
Date: Sat, 8 Nov 2008 14:42:25 +0300 [thread overview]
Message-ID: <20081108114225.GA22674@ioremap.net> (raw)
Hi.
Attached patch puts pid into unused cookie field in inotify events.
Cookie from move command were not changed.
Having pid of the event origin is very useful for the notification
daemons which have to differentiate 'local' and 'remote' users, i.e.
those which have different policies. One of the examples is libionotify
(an IO notiication library) and POHMELFS server.
Also fixed several whitespace issues.
1. libionotify
http://www.ioremap.net/projects/libionotify
2. POHMELFS
http://www.ioremap.net/projects/pohmelfs
Signed-off-by: Evgeniy Polyakov <zbr@ioremap.net>
diff --git a/include/linux/fsnotify.h b/include/linux/fsnotify.h
index d4b7c4a..4a10dff 100644
--- a/include/linux/fsnotify.h
+++ b/include/linux/fsnotify.h
@@ -55,7 +55,7 @@ static inline void fsnotify_move(struct inode *old_dir, struct inode *new_dir,
if (isdir)
isdir = IN_ISDIR;
- inotify_inode_queue_event(old_dir, IN_MOVED_FROM|isdir,cookie,old_name,
+ inotify_inode_queue_event(old_dir, IN_MOVED_FROM|isdir,cookie, old_name,
source);
inotify_inode_queue_event(new_dir, IN_MOVED_TO|isdir, cookie, new_name,
source);
@@ -79,7 +79,8 @@ static inline void fsnotify_nameremove(struct dentry *dentry, int isdir)
if (isdir)
isdir = IN_ISDIR;
dnotify_parent(dentry, DN_DELETE);
- inotify_dentry_parent_queue_event(dentry, IN_DELETE|isdir, 0, dentry->d_name.name);
+ inotify_dentry_parent_queue_event(dentry, IN_DELETE|isdir,
+ task_tgid_vnr(current), dentry->d_name.name);
}
/*
@@ -87,7 +88,8 @@ static inline void fsnotify_nameremove(struct dentry *dentry, int isdir)
*/
static inline void fsnotify_inoderemove(struct inode *inode)
{
- inotify_inode_queue_event(inode, IN_DELETE_SELF, 0, NULL, NULL);
+ inotify_inode_queue_event(inode, IN_DELETE_SELF,
+ task_tgid_vnr(current), NULL, NULL);
inotify_inode_is_dead(inode);
}
@@ -96,7 +98,8 @@ static inline void fsnotify_inoderemove(struct inode *inode)
*/
static inline void fsnotify_link_count(struct inode *inode)
{
- inotify_inode_queue_event(inode, IN_ATTRIB, 0, NULL, NULL);
+ inotify_inode_queue_event(inode, IN_ATTRIB,
+ task_tgid_vnr(current), NULL, NULL);
}
/*
@@ -105,8 +108,8 @@ static inline void fsnotify_link_count(struct inode *inode)
static inline void fsnotify_create(struct inode *inode, struct dentry *dentry)
{
inode_dir_notify(inode, DN_CREATE);
- inotify_inode_queue_event(inode, IN_CREATE, 0, dentry->d_name.name,
- dentry->d_inode);
+ inotify_inode_queue_event(inode, IN_CREATE, task_tgid_vnr(current),
+ dentry->d_name.name, dentry->d_inode);
audit_inode_child(dentry->d_name.name, dentry, inode);
}
@@ -118,8 +121,8 @@ static inline void fsnotify_create(struct inode *inode, struct dentry *dentry)
static inline void fsnotify_link(struct inode *dir, struct inode *inode, struct dentry *new_dentry)
{
inode_dir_notify(dir, DN_CREATE);
- inotify_inode_queue_event(dir, IN_CREATE, 0, new_dentry->d_name.name,
- inode);
+ inotify_inode_queue_event(dir, IN_CREATE, task_tgid_vnr(current),
+ new_dentry->d_name.name, inode);
fsnotify_link_count(inode);
audit_inode_child(new_dentry->d_name.name, new_dentry, dir);
}
@@ -130,8 +133,8 @@ static inline void fsnotify_link(struct inode *dir, struct inode *inode, struct
static inline void fsnotify_mkdir(struct inode *inode, struct dentry *dentry)
{
inode_dir_notify(inode, DN_CREATE);
- inotify_inode_queue_event(inode, IN_CREATE | IN_ISDIR, 0,
- dentry->d_name.name, dentry->d_inode);
+ inotify_inode_queue_event(inode, IN_CREATE | IN_ISDIR,
+ task_tgid_vnr(current), dentry->d_name.name, dentry->d_inode);
audit_inode_child(dentry->d_name.name, dentry, inode);
}
@@ -147,8 +150,9 @@ static inline void fsnotify_access(struct dentry *dentry)
mask |= IN_ISDIR;
dnotify_parent(dentry, DN_ACCESS);
- inotify_dentry_parent_queue_event(dentry, mask, 0, dentry->d_name.name);
- inotify_inode_queue_event(inode, mask, 0, NULL, NULL);
+ inotify_dentry_parent_queue_event(dentry, mask,
+ task_tgid_vnr(current), dentry->d_name.name);
+ inotify_inode_queue_event(inode, mask, task_tgid_vnr(current), NULL, NULL);
}
/*
@@ -163,8 +167,9 @@ static inline void fsnotify_modify(struct dentry *dentry)
mask |= IN_ISDIR;
dnotify_parent(dentry, DN_MODIFY);
- inotify_dentry_parent_queue_event(dentry, mask, 0, dentry->d_name.name);
- inotify_inode_queue_event(inode, mask, 0, NULL, NULL);
+ inotify_dentry_parent_queue_event(dentry, mask,
+ task_tgid_vnr(current), dentry->d_name.name);
+ inotify_inode_queue_event(inode, mask, task_tgid_vnr(current), NULL, NULL);
}
/*
@@ -178,8 +183,10 @@ static inline void fsnotify_open(struct dentry *dentry)
if (S_ISDIR(inode->i_mode))
mask |= IN_ISDIR;
- inotify_dentry_parent_queue_event(dentry, mask, 0, dentry->d_name.name);
- inotify_inode_queue_event(inode, mask, 0, NULL, NULL);
+ inotify_dentry_parent_queue_event(dentry, mask,
+ task_tgid_vnr(current), dentry->d_name.name);
+ inotify_inode_queue_event(inode, mask,
+ task_tgid_vnr(current), NULL, NULL);
}
/*
@@ -196,8 +203,8 @@ static inline void fsnotify_close(struct file *file)
if (S_ISDIR(inode->i_mode))
mask |= IN_ISDIR;
- inotify_dentry_parent_queue_event(dentry, mask, 0, name);
- inotify_inode_queue_event(inode, mask, 0, NULL, NULL);
+ inotify_dentry_parent_queue_event(dentry, mask, task_tgid_vnr(current), name);
+ inotify_inode_queue_event(inode, mask, task_tgid_vnr(current), NULL, NULL);
}
/*
@@ -211,8 +218,10 @@ static inline void fsnotify_xattr(struct dentry *dentry)
if (S_ISDIR(inode->i_mode))
mask |= IN_ISDIR;
- inotify_dentry_parent_queue_event(dentry, mask, 0, dentry->d_name.name);
- inotify_inode_queue_event(inode, mask, 0, NULL, NULL);
+ inotify_dentry_parent_queue_event(dentry, mask,
+ task_tgid_vnr(current), dentry->d_name.name);
+ inotify_inode_queue_event(inode, mask,
+ task_tgid_vnr(current), NULL, NULL);
}
/*
@@ -259,9 +268,10 @@ static inline void fsnotify_change(struct dentry *dentry, unsigned int ia_valid)
if (in_mask) {
if (S_ISDIR(inode->i_mode))
in_mask |= IN_ISDIR;
- inotify_inode_queue_event(inode, in_mask, 0, NULL, NULL);
- inotify_dentry_parent_queue_event(dentry, in_mask, 0,
- dentry->d_name.name);
+ inotify_inode_queue_event(inode, in_mask,
+ task_tgid_vnr(current), NULL, NULL);
+ inotify_dentry_parent_queue_event(dentry, in_mask,
+ task_tgid_vnr(current), dentry->d_name.name);
}
}
--
Evgeniy Polyakov
next reply other threads:[~2008-11-08 11:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 11:42 Evgeniy Polyakov [this message]
2008-11-08 14:25 ` [1/1] Use pid in inotify events Michael Kerrisk
2008-11-08 15:35 ` Evgeniy Polyakov
2008-11-08 16:58 ` Michael Kerrisk
2008-11-08 17:04 ` Robert Love
2008-11-08 17:27 ` Evgeniy Polyakov
2008-11-10 15:20 ` Evgeniy Polyakov
2008-11-10 17:15 ` Michael Kerrisk
2008-11-10 17:20 ` Evgeniy Polyakov
[not found] <acdcfe7e0811081035l56eedf05x8b3b7ee2fc01eee6@mail.gmail.com>
2008-11-08 18:40 ` Evgeniy Polyakov
2008-11-08 22:03 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081108114225.GA22674@ioremap.net \
--to=zbr@ioremap.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=rlove@rlove.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox