public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Ken Chen <kenchen@google.com>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [patch] add /proc/pid/stack to dump task's stack trace
Date: Sat, 8 Nov 2008 13:06:01 +0100	[thread overview]
Message-ID: <20081108120601.GF8354@elte.hu> (raw)
In-Reply-To: <20081107175157.GB3469@x200.localdomain>


* Alexey Dobriyan <adobriyan@gmail.com> wrote:

> >  1) only root should be allowed to do this - i.e. file needs to be 
> >     root-owned.
> >
> >  2) there also needs to be a .config entry for folks to be able to
> >     turn it off altogether - just like folks can turn off sysrq-t 
> >     dumping via the .config.
> 
> In the name of everything holy, don't add another config option. 
> It's a _tiny_ piece of code and you have select STACKTRACE via fault 
> injection, latencytop or lockdep before that.

We could make it depend on DEBUG_KERNEL or so, and always select 
STACKTRACE infrastructure when DEBUG_KERNEL is enabled? There's no 
reason not to get high quality backtraces via /proc when one debugs 
the kernel.

	Ingo

  reply	other threads:[~2008-11-08 12:06 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-06 19:01 [patch] add /proc/pid/stack to dump task's stack trace Ken Chen
2008-11-06 19:51 ` Alexey Dobriyan
2008-11-06 20:12   ` Ken Chen
2008-11-06 20:35     ` Ingo Molnar
2008-11-07  0:30       ` Ken Chen
2008-11-07  0:48         ` Alexey Dobriyan
2008-11-07  7:41           ` Ingo Molnar
2008-11-07  7:59             ` Ingo Molnar
2008-11-07  8:20               ` Alexey Dobriyan
2008-11-07  8:32                 ` Ingo Molnar
2008-11-07  8:49                   ` Alexey Dobriyan
2008-11-07  8:53                     ` Ingo Molnar
2008-11-07  9:03                       ` Ingo Molnar
2008-11-07  9:16                         ` Andrew Morton
2008-11-07  9:29                           ` Ingo Molnar
2008-11-07 17:51                             ` Alexey Dobriyan
2008-11-08 12:06                               ` Ingo Molnar [this message]
2008-11-10 23:54                             ` Andrew Morton
2008-11-11 10:00                               ` Ingo Molnar
2008-11-11 12:25                         ` Marcin Slusarz
2008-11-11 12:33                           ` Alexey Dobriyan
2008-11-11 13:20                           ` Ingo Molnar
2008-11-11 14:03                             ` Mikael Pettersson
2008-11-11 14:19                               ` Ingo Molnar
2008-11-07 18:38                   ` Ken Chen
2008-11-07 18:46                     ` Paul Menage
2008-11-08 12:10                     ` Ingo Molnar
2008-11-09 18:08                       ` Alexey Dobriyan
2008-11-10  8:41                         ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081108120601.GF8354@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=kenchen@google.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox