From: Evgeniy Polyakov <zbr@ioremap.net>
To: mtk.manpages@gmail.com
Cc: linux-kernel@vger.kernel.org, Robert Love <rlove@rlove.org>,
linux-api@vger.kernel.org
Subject: Re: [1/1] Use pid in inotify events.
Date: Sat, 8 Nov 2008 18:35:45 +0300 [thread overview]
Message-ID: <20081108153545.GA3859@ioremap.net> (raw)
In-Reply-To: <cfd18e0f0811080625w5b285cc0p2410e8d187b025c7@mail.gmail.com>
Hi Michael.
On Sat, Nov 08, 2008 at 09:25:16AM -0500, Michael Kerrisk (mtk.manpages@googlemail.com) wrote:
> I've not looked closely at the patch, but a quick question. The
> ookied field is unused for _most_ events, but is used for rename
> events. Are you saying that with this patch, that the cookie will be
> used as before for rename events, but for other events it will be the
> PID of the triggering process? If so, that seems a bit ugly -- why
> wouldn't we also be intersted in the PID for rename events?
Yes, rename events actually consist of at least two: move from and move
to, and they carry the same cookie, so that userspace could combine them
into single transaction. All others use zero, so I decided to put PID of
the caller there. This does not look perfect of course, but we can not
change the structure layout, so rename events can not be changed to
carry additional PID field.
--
Evgeniy Polyakov
next prev parent reply other threads:[~2008-11-08 15:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-08 11:42 [1/1] Use pid in inotify events Evgeniy Polyakov
2008-11-08 14:25 ` Michael Kerrisk
2008-11-08 15:35 ` Evgeniy Polyakov [this message]
2008-11-08 16:58 ` Michael Kerrisk
2008-11-08 17:04 ` Robert Love
2008-11-08 17:27 ` Evgeniy Polyakov
2008-11-10 15:20 ` Evgeniy Polyakov
2008-11-10 17:15 ` Michael Kerrisk
2008-11-10 17:20 ` Evgeniy Polyakov
[not found] <acdcfe7e0811081035l56eedf05x8b3b7ee2fc01eee6@mail.gmail.com>
2008-11-08 18:40 ` Evgeniy Polyakov
2008-11-08 22:03 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081108153545.GA3859@ioremap.net \
--to=zbr@ioremap.net \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=rlove@rlove.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox